Merged
Conversation
brunobar79
approved these changes
Nov 27, 2018
Contributor
brunobar79
left a comment
brunobar79
left a comment
There was a problem hiding this comment.
This is amazing @estebanmino! 💪
I've added a couple of comments but nothing major.
Once you get GABA's PR merged in and the tests passing you can merge it in.
| </View> | ||
| <View> | ||
| <Text>{strings('signature_request.balance_title')}</Text> | ||
| <Text style={styles.text}>{balance} ETH</Text> |
Contributor
There was a problem hiding this comment.
Should this be the global currency instead of ETH?
Contributor
Author
There was a problem hiding this comment.
I'll make this change for the whole app, we're using plain ETH everywhere
Contributor
There was a problem hiding this comment.
Makes sense. Can you open an issue and mark this one as resolved?
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* update browser url regex to match local url * add gaba message manager * add eth_sign support with minimal UI * update eth sign UI as extension * add and use personal_sign instead of eth_sign * use keyrong personal sign message instead of sign message * use strings unit eth instead of plain ETH rendering components * fix account label not showing on signature request * Update GABA version * update snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for both eth_sign and personal_sign, using this MetaMask/core#29 version of GABA [BLOCKER].
Checklist
Issue
Resolves #169
Resolves #189