docs: update feature flag registry documentation#40554
Merged
Unik0rnMaggie merged 6 commits intomainfrom Mar 5, 2026
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Builds ready [d601b51]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs
|
Contributor
Builds ready [100db3a]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
LeVinhGithub
reviewed
Mar 4, 2026
LeVinhGithub
reviewed
Mar 4, 2026
Contributor
Builds ready [b82354c]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
LeVinhGithub
previously approved these changes
Mar 4, 2026
DDDDDanica
reviewed
Mar 4, 2026
DDDDDanica
reviewed
Mar 4, 2026
DDDDDanica
reviewed
Mar 4, 2026
DDDDDanica
reviewed
Mar 4, 2026
DDDDDanica
reviewed
Mar 4, 2026
DDDDDanica
reviewed
Mar 4, 2026
DDDDDanica
reviewed
Mar 4, 2026
|
Contributor
Builds ready [1163560]
⚡ Performance Benchmarks
🌐 Dapp Page Load BenchmarksCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
approved these changes
Mar 4, 2026
Contributor
|
LGTM ! ✅ |
LeVinhGithub
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Add a new Feature Flag Registry section to
README.mdto document how remote flags are managed for E2E tests.Explain the full workflow: production source-of-truth, E2E mock behavior, CI enforcement via
check-feature-flag-registry, and registry entry format.Document contributor guidance for adding, overriding, and removing feature flags, including helper utilities and constant mapping requirements.
The feature flag registry and CI check were added to keep flag usage production-accurate and prevent untracked flag references. This documentation makes the workflow discoverable and reduces onboarding/friction for contributors updating or introducing flags.
Changelog
CHANGELOG entry: null
Related issues
Fixes: MMQA-1481
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Low Risk
Low risk: documentation-only changes with no runtime behavior modifications.
Overview
Updates
README.mdE2E guidance to clearly separate remote (runtime) vs build-time (compile-time) feature flags and points to the recommended test-time override mechanisms (manifestFlagsinwithFixtures, legacyFixtureBuilder.withRemoteFeatureFlags()).Adds a new Feature Flag Registry section documenting
test/e2e/feature-flags/feature-flag-registry.tsas the source of truth for remote flags in E2E, how thecheck-feature-flag-registryCI job enforces registry coverage, and contributor steps to add/override/remove flags (including constant mapping in.github/scripts/known-feature-flag-constants.ts).Written by Cursor Bugbot for commit 1163560. This will update automatically on new commits. Configure here.