feat: support atomic batch transactions by matthewwalsh0 · Pull Request #5306 · MetaMask/core

matthewwalsh0 · 2025-02-11T10:28:52Z

Explanation

Support atomic batch transactions via EIP-7702, and ERC-7821.

Specifically:

Add addTransactionBatch method with TransactionBatchRequest and TransactionBatchResult types.
Encode multiple transactions into single execute call using ERC-7821 ABI.
Automatically upgrade account via setCode transaction if needed.
Add isAtomicBatchSupported method to identify which chains support atomic batch for a given account.
Add new batch TransactionType.
Add batch utils to encapsulate all batch-related logic.
Add feature-flags utils to encapsulate retrieval and fallback of LaunchDarkly configuration.
- Currently EIP-7702 chains and contract addresses.
Validate to of external transaction is not an internal account unless transactionType is batch.

References

Fixes #4096

Changelog

See CHANGELOG.md.

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've highlighted breaking changes using the "BREAKING" category above as appropriate
I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Create prepare utils.

Add initial unit tests.

Add feature flags util.

matthewwalsh0 · 2025-02-12T09:47:57Z

@metamaskbot publish-preview

github-actions · 2025-02-12T09:52:13Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/accounts-controller": "23.0.1-preview-ee98fad1",
  "@metamask-previews/address-book-controller": "6.0.3-preview-ee98fad1",
  "@metamask-previews/announcement-controller": "7.0.3-preview-ee98fad1",
  "@metamask-previews/approval-controller": "7.1.3-preview-ee98fad1",
  "@metamask-previews/assets-controllers": "49.0.0-preview-ee98fad1",
  "@metamask-previews/base-controller": "8.0.0-preview-ee98fad1",
  "@metamask-previews/build-utils": "3.0.3-preview-ee98fad1",
  "@metamask-previews/composable-controller": "11.0.0-preview-ee98fad1",
  "@metamask-previews/controller-utils": "11.5.0-preview-ee98fad1",
  "@metamask-previews/earn-controller": "0.2.1-preview-ee98fad1",
  "@metamask-previews/ens-controller": "15.0.2-preview-ee98fad1",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-ee98fad1",
  "@metamask-previews/gas-fee-controller": "22.0.3-preview-ee98fad1",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-ee98fad1",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-ee98fad1",
  "@metamask-previews/keyring-controller": "19.0.7-preview-ee98fad1",
  "@metamask-previews/logging-controller": "6.0.4-preview-ee98fad1",
  "@metamask-previews/message-manager": "12.0.1-preview-ee98fad1",
  "@metamask-previews/multichain": "2.1.1-preview-ee98fad1",
  "@metamask-previews/multichain-transactions-controller": "0.3.0-preview-ee98fad1",
  "@metamask-previews/name-controller": "8.0.3-preview-ee98fad1",
  "@metamask-previews/network-controller": "22.2.1-preview-ee98fad1",
  "@metamask-previews/notification-services-controller": "0.20.1-preview-ee98fad1",
  "@metamask-previews/permission-controller": "11.0.6-preview-ee98fad1",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-ee98fad1",
  "@metamask-previews/phishing-controller": "12.3.2-preview-ee98fad1",
  "@metamask-previews/polling-controller": "12.0.3-preview-ee98fad1",
  "@metamask-previews/preferences-controller": "15.0.2-preview-ee98fad1",
  "@metamask-previews/profile-sync-controller": "7.0.1-preview-ee98fad1",
  "@metamask-previews/queued-request-controller": "9.0.1-preview-ee98fad1",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-ee98fad1",
  "@metamask-previews/remote-feature-flag-controller": "1.4.0-preview-ee98fad1",
  "@metamask-previews/selected-network-controller": "21.0.1-preview-ee98fad1",
  "@metamask-previews/signature-controller": "23.2.1-preview-ee98fad1",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-ee98fad1",
  "@metamask-previews/transaction-controller": "45.1.0-preview-ee98fad1",
  "@metamask-previews/user-operation-controller": "24.0.1-preview-ee98fad1"
}

matthewwalsh0 · 2025-02-12T10:56:10Z

@metamaskbot publish-preview

github-actions · 2025-02-12T11:00:35Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/accounts-controller": "23.0.1-preview-862b5dac",
  "@metamask-previews/address-book-controller": "6.0.3-preview-862b5dac",
  "@metamask-previews/announcement-controller": "7.0.3-preview-862b5dac",
  "@metamask-previews/approval-controller": "7.1.3-preview-862b5dac",
  "@metamask-previews/assets-controllers": "49.0.0-preview-862b5dac",
  "@metamask-previews/base-controller": "8.0.0-preview-862b5dac",
  "@metamask-previews/build-utils": "3.0.3-preview-862b5dac",
  "@metamask-previews/composable-controller": "11.0.0-preview-862b5dac",
  "@metamask-previews/controller-utils": "11.5.0-preview-862b5dac",
  "@metamask-previews/earn-controller": "0.2.1-preview-862b5dac",
  "@metamask-previews/ens-controller": "15.0.2-preview-862b5dac",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-862b5dac",
  "@metamask-previews/gas-fee-controller": "22.0.3-preview-862b5dac",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-862b5dac",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-862b5dac",
  "@metamask-previews/keyring-controller": "19.0.7-preview-862b5dac",
  "@metamask-previews/logging-controller": "6.0.4-preview-862b5dac",
  "@metamask-previews/message-manager": "12.0.1-preview-862b5dac",
  "@metamask-previews/multichain": "2.1.1-preview-862b5dac",
  "@metamask-previews/multichain-transactions-controller": "0.3.0-preview-862b5dac",
  "@metamask-previews/name-controller": "8.0.3-preview-862b5dac",
  "@metamask-previews/network-controller": "22.2.1-preview-862b5dac",
  "@metamask-previews/notification-services-controller": "0.20.1-preview-862b5dac",
  "@metamask-previews/permission-controller": "11.0.6-preview-862b5dac",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-862b5dac",
  "@metamask-previews/phishing-controller": "12.3.2-preview-862b5dac",
  "@metamask-previews/polling-controller": "12.0.3-preview-862b5dac",
  "@metamask-previews/preferences-controller": "15.0.2-preview-862b5dac",
  "@metamask-previews/profile-sync-controller": "7.0.1-preview-862b5dac",
  "@metamask-previews/queued-request-controller": "9.0.1-preview-862b5dac",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-862b5dac",
  "@metamask-previews/remote-feature-flag-controller": "1.4.0-preview-862b5dac",
  "@metamask-previews/selected-network-controller": "21.0.1-preview-862b5dac",
  "@metamask-previews/signature-controller": "23.2.1-preview-862b5dac",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-862b5dac",
  "@metamask-previews/transaction-controller": "45.1.0-preview-862b5dac",
  "@metamask-previews/user-operation-controller": "24.0.1-preview-862b5dac"
}

matthewwalsh0 · 2025-02-12T14:49:12Z

@metamaskbot publish-preview

github-actions · 2025-02-12T14:53:37Z

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.

{
  "@metamask-previews/accounts-controller": "23.0.1-preview-f51ef7f8",
  "@metamask-previews/address-book-controller": "6.0.3-preview-f51ef7f8",
  "@metamask-previews/announcement-controller": "7.0.3-preview-f51ef7f8",
  "@metamask-previews/approval-controller": "7.1.3-preview-f51ef7f8",
  "@metamask-previews/assets-controllers": "49.0.0-preview-f51ef7f8",
  "@metamask-previews/base-controller": "8.0.0-preview-f51ef7f8",
  "@metamask-previews/build-utils": "3.0.3-preview-f51ef7f8",
  "@metamask-previews/composable-controller": "11.0.0-preview-f51ef7f8",
  "@metamask-previews/controller-utils": "11.5.0-preview-f51ef7f8",
  "@metamask-previews/earn-controller": "0.2.1-preview-f51ef7f8",
  "@metamask-previews/ens-controller": "15.0.2-preview-f51ef7f8",
  "@metamask-previews/eth-json-rpc-provider": "4.1.8-preview-f51ef7f8",
  "@metamask-previews/gas-fee-controller": "22.0.3-preview-f51ef7f8",
  "@metamask-previews/json-rpc-engine": "10.0.3-preview-f51ef7f8",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.7-preview-f51ef7f8",
  "@metamask-previews/keyring-controller": "19.0.7-preview-f51ef7f8",
  "@metamask-previews/logging-controller": "6.0.4-preview-f51ef7f8",
  "@metamask-previews/message-manager": "12.0.1-preview-f51ef7f8",
  "@metamask-previews/multichain": "2.1.1-preview-f51ef7f8",
  "@metamask-previews/multichain-transactions-controller": "0.3.0-preview-f51ef7f8",
  "@metamask-previews/name-controller": "8.0.3-preview-f51ef7f8",
  "@metamask-previews/network-controller": "22.2.1-preview-f51ef7f8",
  "@metamask-previews/notification-services-controller": "0.20.1-preview-f51ef7f8",
  "@metamask-previews/permission-controller": "11.0.6-preview-f51ef7f8",
  "@metamask-previews/permission-log-controller": "3.0.3-preview-f51ef7f8",
  "@metamask-previews/phishing-controller": "12.3.2-preview-f51ef7f8",
  "@metamask-previews/polling-controller": "12.0.3-preview-f51ef7f8",
  "@metamask-previews/preferences-controller": "15.0.2-preview-f51ef7f8",
  "@metamask-previews/profile-sync-controller": "7.0.1-preview-f51ef7f8",
  "@metamask-previews/queued-request-controller": "9.0.1-preview-f51ef7f8",
  "@metamask-previews/rate-limit-controller": "6.0.3-preview-f51ef7f8",
  "@metamask-previews/remote-feature-flag-controller": "1.4.0-preview-f51ef7f8",
  "@metamask-previews/selected-network-controller": "21.0.1-preview-f51ef7f8",
  "@metamask-previews/signature-controller": "23.2.1-preview-f51ef7f8",
  "@metamask-previews/token-search-discovery-controller": "2.1.0-preview-f51ef7f8",
  "@metamask-previews/transaction-controller": "45.1.0-preview-f51ef7f8",
  "@metamask-previews/user-operation-controller": "24.0.1-preview-f51ef7f8"
}

packages/transaction-controller/src/utils/feature-flags.ts

packages/transaction-controller/src/utils/eip7702.ts

packages/transaction-controller/src/utils/batch.ts

packages/transaction-controller/src/TransactionController.ts

packages/transaction-controller/src/TransactionController.test.ts

packages/transaction-controller/src/utils/feature-flags.ts

matthewwalsh0 added 30 commits February 4, 2025 10:17

Upgrade ethereumjs packages

5fc40a1

Create prepare utils.

Add unit tests for prepare utils

d7ba1a7

Update types

2e116ac

Add validation

495f1d6

Add signing

e696ac0

Add initial unit tests.

Update hardfork

d52b567

Add additional 7702 unit tests

7407517

Add origin validation

1676b5e

Fix linting and unit test coverage

e85731b

Align upgrades

8df08d5

Update yarn lock

f253296

Update thresholds

29e09cd

Merge branch 'main' into feat/type-4-transactions

47cd630

Revert upgrades

d335bc4

Use utils bytesToHex

2a6578b

Add types

b6494b2

Add supported account and chain utils

cca282f

Add generate transaction function

446e337

Add batch method

789bd71

Convert to type 4

50bc5fc

Add feature flags util.

Add feature flag unit tests

751ed20

Add batch unit tests

62fd88b

Add unit test

84fd250

Add nested transactions property

f8819a4

Add isAtomicBatchSupported method

202ea06

Validate to is not internal

c3ac61a

Merge branch 'main' into feat/transaction-batch

7fabfc7

Fix linting

5081e27

Merge branch 'main' into feat/transaction-batch

efeb158

Fix dependencies

5d2ca68

Update changelog

ee98fad

matthewwalsh0 marked this pull request as ready for review February 12, 2025 10:47

matthewwalsh0 requested review from a team as code owners February 12, 2025 10:47

Move ABI

862b5da

Fix linting

538a67a

Update sign action

f51ef7f

jpuri reviewed Feb 14, 2025

View reviewed changes

packages/transaction-controller/src/utils/feature-flags.ts Show resolved Hide resolved

pedronfigueiredo previously approved these changes Feb 14, 2025

View reviewed changes

jpuri reviewed Feb 14, 2025

View reviewed changes

packages/transaction-controller/src/utils/eip7702.ts Show resolved Hide resolved

jpuri reviewed Feb 14, 2025

View reviewed changes

packages/transaction-controller/src/utils/batch.ts Show resolved Hide resolved

OGPoyraz previously approved these changes Feb 17, 2025

View reviewed changes

packages/transaction-controller/src/TransactionController.ts Show resolved Hide resolved

packages/transaction-controller/src/TransactionController.test.ts Outdated Show resolved Hide resolved

packages/transaction-controller/src/utils/feature-flags.ts Show resolved Hide resolved

Merge branch 'main' into feat/transaction-batch

97e6eaa

matthewwalsh0 dismissed stale reviews from OGPoyraz and pedronfigueiredo via 97e6eaa February 17, 2025 10:40

matthewwalsh0 added 2 commits February 17, 2025 10:45

Add JSDoc

cea55f7

Fix changelog

2def82d

matthewwalsh0 requested review from OGPoyraz and pedronfigueiredo February 17, 2025 11:36

pedronfigueiredo approved these changes Feb 17, 2025

View reviewed changes

OGPoyraz approved these changes Feb 17, 2025

View reviewed changes

jpuri approved these changes Feb 17, 2025

View reviewed changes

matthewwalsh0 merged commit b9cb503 into main Feb 17, 2025

matthewwalsh0 deleted the feat/transaction-batch branch February 17, 2025 12:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: support atomic batch transactions#5306

feat: support atomic batch transactions#5306
matthewwalsh0 merged 43 commits intomainfrom
feat/transaction-batch

matthewwalsh0 commented Feb 11, 2025 •

edited

Loading

Uh oh!

matthewwalsh0 commented Feb 12, 2025

Uh oh!

github-actions bot commented Feb 12, 2025

Uh oh!

matthewwalsh0 commented Feb 12, 2025

Uh oh!

github-actions bot commented Feb 12, 2025

Uh oh!

matthewwalsh0 commented Feb 12, 2025

Uh oh!

github-actions bot commented Feb 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

matthewwalsh0 commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

References

Changelog

Checklist

Uh oh!

matthewwalsh0 commented Feb 12, 2025

Uh oh!

github-actions bot commented Feb 12, 2025

Uh oh!

matthewwalsh0 commented Feb 12, 2025

Uh oh!

github-actions bot commented Feb 12, 2025

Uh oh!

matthewwalsh0 commented Feb 12, 2025

Uh oh!

github-actions bot commented Feb 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

matthewwalsh0 commented Feb 11, 2025 •

edited

Loading