Merged
Conversation
Gudahtt
reviewed
Mar 19, 2024
packages/assets-controllers/src/Standards/NftStandards/ERC1155/ERC1155Standard.test.ts
Show resolved
Hide resolved
Gudahtt
approved these changes
Mar 19, 2024
Member
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM! Just one non-blocking suggested for an additional unit test
Merged
sahar-fehri
added a commit
that referenced
this pull request
Mar 19, 2024
This is the release candidate for 129.0.0. It adds an export for const SUPPORTED_CHAIN_IDS. #4079
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
PR to export
SUPPORTED_CHAIN_IDSconstant.This constant is imported in extension like this:
import { SUPPORTED_CHAIN_IDS } from '@metamask/assets-controllers/dist/token-prices-service/codefi-v2';Which was causing issues when trying to upgrade assets-controllers to latest. It was not able to find it.
With this change we can import it like this instead of from dist which can abstract how the code is transpiled;
import { SUPPORTED_CHAIN_IDS } from '@metamask/assets-controllers';References
Changelog
@metamask/assets-controllersChecklist