Add BaseControllerV2 schema #359
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This depends upon #358 |
Gudahtt
force-pushed
the
add-base-controller-schema
branch
from
6955b3d to
4ed5295
Compare
Gudahtt
force-pushed
the
add-base-controller-schema
branch
from
4ed5295 to
ded054c
Compare
Member
Author
|
Replaced by #362 |
Mrtenz
pushed a commit
that referenced
this pull request
Oct 16, 2025
Support the EIP-5792 methods:
- `wallet_sendCalls`
- `wallet_getCallsStatus`
- `wallet_getCapabilities`
Specifically:
- Modularise new method support into separate files under `src/methods`.
- As opposed to continually extending `src/wallet.ts`.
- Use `@metamask/superstruct` to easily validate request parameters
against a schema / struct.
- Move common validation functions to new `src/validation.ts`.
- Export new types inferred from structs.
- Specifically as opposed to `*` for easier API diffs.
An additional benefit of using `@metamask/superstruct` is including
multiple validation errors within a single RPC error:
```
Error: Invalid params
0 > from - Expected a string matching \`/^0x[0-9a-fA-F]{40}$/\` but received "123"
0 > chainId - Expected a string, but received: 123
0 > calls - Expected an array value, but received: "123"
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A schema has been added to the new BaseController class as a required constructor parameter. The schema describes which pieces of state should be persisted, and how to get an 'anonymized' snapshot of the controller state.
This is part of the controller redesign (#337).