Conversation
packages/transaction-controller/src/TransactionController.test.ts
Outdated
Show resolved
Hide resolved
packages/transaction-controller/src/TransactionController.test.ts
Outdated
Show resolved
Hide resolved
OGPoyraz
force-pushed
the
1074-add-dappsuggestedgasfees-to-transaction-state-in-core-transaction-controller
branch
2 times, most recently
from
fc0409f to
65ac7c8
Compare
| /** | ||
| * Maximum fee per gas for this transaction. | ||
| */ | ||
| maxFeePerGas?: string; |
Member
There was a problem hiding this comment.
We're alphabetical up to here, shall we take the opportunity to order the rest?
Member
Author
There was a problem hiding this comment.
Idk how did I missed it heh
OGPoyraz
force-pushed
the
1074-add-dappsuggestedgasfees-to-transaction-state-in-core-transaction-controller
branch
from
ab9baf4 to
e003142
Compare
OGPoyraz
force-pushed
the
1074-add-dappsuggestedgasfees-to-transaction-state-in-core-transaction-controller
branch
from
e003142 to
53416b3
Compare
matthewwalsh0
approved these changes
Aug 25, 2023
vinistevam
approved these changes
Aug 25, 2023
OGPoyraz
deleted the
1074-add-dappsuggestedgasfees-to-transaction-state-in-core-transaction-controller
branch
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR aims to add
dappSuggestedGasFeesif transaction creation origin is not MetaMask.Changelog
@metamask/transaction-controllerdappSuggestedGasFeesto transaction metaChecklist