Add baseFeePerGas to transaction state#1590
Merged
vinistevam merged 5 commits intomainfrom Aug 23, 2023
Merged
Conversation
OGPoyraz
reviewed
Aug 17, 2023
vinistevam
force-pushed
the
1072-add-baseFeePerGas-transaction-state
branch
from
b95637f to
ab873ca
Compare
OGPoyraz
previously approved these changes
Aug 18, 2023
matthewwalsh0
previously approved these changes
Aug 22, 2023
OGPoyraz
previously approved these changes
Aug 23, 2023
Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
vinistevam
force-pushed
the
1072-add-baseFeePerGas-transaction-state
branch
from
5f0abd7 to
3edbc49
Compare
matthewwalsh0
approved these changes
Aug 23, 2023
OGPoyraz
approved these changes
Aug 23, 2023
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
The extension
TransactionControllerpersists in abaseFeePerGasvalue for each confirmed transaction. Including this property into the transaction state in the core to support the unification initiative between the core and extension.References
Fixes https://github.com/MetaMask/MetaMask-planning/issues/1072
Changelog
@metamask/transaction-controllerbaseFeePerGasto the transaction state and persists the value for each confirmed transactionChecklist