Merged
Conversation
OGPoyraz
force-pushed
the
963-minimise-the-public-api-of-the-core-transaction-controller
branch
2 times, most recently
from
1b16784 to
3684f32
Compare
OGPoyraz
force-pushed
the
963-minimise-the-public-api-of-the-core-transaction-controller
branch
from
3684f32 to
78eab73
Compare
vinistevam
approved these changes
Aug 17, 2023
…saction-controller
matthewwalsh0
approved these changes
Aug 17, 2023
Contributor
|
Should we note these changes as breaking in the PR description just so we're more aware of them? |
…saction-controller
Member
Author
This is already been checked on mobile and make sure that there are no usage. But technically still a BC, so I marked it. |
OGPoyraz
deleted the
963-minimise-the-public-api-of-the-core-transaction-controller
branch
Merged
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR aims to pull couple of public methods into private since they are not used by clients.
Changelog
@metamask/transaction-controllerprepareUnsignedEthTxandgetCommonConfigurationmethods to private.Checklist