Conversation
OGPoyraz
changed the title
addTransaction public API method
…thod-in-core-transaction-controller
Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
…thod-in-core-transaction-controller
Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
Co-authored-by: Matthew Walsh <matthew.walsh@consensys.net>
matthewwalsh0
approved these changes
Aug 14, 2023
OGPoyraz
deleted the
1050-use-options-object-in-addtransaction-method-in-core-transaction-controller
branch
OGPoyraz
added a commit
that referenced
this pull request
Aug 15, 2023
Merged
3 tasks
OGPoyraz
added a commit
that referenced
this pull request
Aug 29, 2023
OGPoyraz
added a commit
that referenced
this pull request
Sep 5, 2023
matthewwalsh0
pushed a commit
that referenced
this pull request
Sep 14, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
matthewwalsh0
pushed a commit
that referenced
this pull request
Dec 17, 2023
matthewwalsh0
pushed a commit
that referenced
this pull request
Feb 18, 2024
matthewwalsh0
pushed a commit
that referenced
this pull request
Mar 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
In order to align Tx controller public APIs between mobile & extension, this PR aims to add an options bag instead of inline arguments for
addTransactionfunction.Changelog
@metamask/transaction-controlleraddTransactionpublic API method instead of inline arguments.Checklist