Issues/11

[jmervine]

Addressing issue #11, sort of. Adding more verbose error messaging.

[kdmny]

Thanks for looking into this. I like the idea of throwing a ServerError or something if the response status code is not in the 2xx range, packaging the raw response inside.

[jmervine]

I like that idea. Just to be clear, you're suggesting added an additional property to the Exception, something like raw_response?

[kdmny]

Yup, That and some explicit exception type that we can catch that
differentiates this kind of error as a remote server error.
On Dec 18, 2014 1:08 PM, "Joshua Mervine" notifications@github.com wrote:

I like that idea. Just to be clear, you're suggesting added an additional
property to the Exception, something like raw_response?

—
Reply to this email directly or view it on GitHub
#12 (comment).

[jmervine]

@kdmny Let me know what you think of the ServerError format I just added. It's more than discussed, but should be complete without being overkill.

Here's a basic example with a forced 404:

>> pprint(error)
ServerError(u'RWS\\Exception:: Resource not found at /jmervine/v3/badreporting/logs.json',)

>> pprint(error.__dict__)
{'body': '{"code":404,"error":{"message":"Resource not found at \\/jmervine\\/v3\\/badreporting\\/logs.json","type":"RWS\\\\Exception"}}',
 'code': 404,
 'headers': {'content-encoding': 'gzip', 'transfer-encoding': 'chunked', 'set-cookie': 'PHPSESSID=7orbutcud1kjh1ofr4i4kiggh0; path=/; secure; HttpOnly', 'expires': 'Thu, 19 Nov 1981 08:52:00 GMT', 'vary': 'Accept-Encoding', 'server': 'nginx', 'connection': 'keep-alive', 'pragma': 'no-cache', 'cache-control': 'no-store, no-cache, must-revalidate, post-check=0, pre-check=0', 'date': 'Thu, 18 Dec 2014 19:15:31 GMT', 'access-control-allow-origin': '*', 'content-type': 'application/json'},
 'reason': u'RWS\\Exception',
 'url': u'https://rws.maxcdn.com/jmervine/v3/badreporting/logs.json?start=2014-12-18T11%3A14%3A31.174058'}

Here's a basic example with a forced ValueError:

>> pprint(err)
ServerError('No JSON object could be decoded',)

>> pprint(err.__dict__)
{'body': 'Some bad JSON content.',
 'code': 200,
 'headers': {'content-encoding': 'gzip', 'transfer-encoding': 'chunked', 'set-cookie': 'PHPSESSID=7orbutcud1kjh1ofr4i4kiggh0; path=/; secure; HttpOnly', 'expires': 'Thu, 19 Nov 1981 08:52:00 GMT', 'vary': 'Accept-Encoding', 'server': 'nginx', 'connection': 'keep-alive', 'pragma': 'no-cache', 'cache-control': 'no-store, no-cache, must-revalidate, post-check=0, pre-check=0', 'date': 'Thu, 18 Dec 2014 19:15:31 GMT', 'access-control-allow-origin': '*', 'content-type': 'application/json'},
 'reason': 'Success',
 'url': 'http://www.example.com/foo/bar'}

[jmervine]

@kdmny Unless you or anyone else has any issue with it, I'll release this as 0.0.5 later this afternoon. Cheers!