fix httpx deprecation warnings
#614
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #613
Fixes httpx deprecation warning when making requests with the atproto client.
The warning was:
Changes
_handle_kwargs()inbase.pyto usecontentparameter instead ofdatawhen passing JSON content to httpx_handle_kwagrs→_handle_kwargsTechnical Details
Recent versions of httpx (0.27.x) have escalated the deprecation warning for using
data=with bytes/text content. The warning was made more visible in PR #3319 (merged October 28, 2024) by addingstacklevel=2to the warning.Since we serialize our models to JSON strings before passing to httpx, we need to use the
contentparameter. The httpx API distinguishes between:content=for raw bytes/text content (what we need for JSON strings)data=for dictionary data that will be form-encodedwhen we detect JSON content type and have data to send, we:
kwargs['data']tokwargs['content']datakey to avoid conflicts