Provide file viewer the option to render Microsoft files#7676
Merged
david-yz-liu merged 3 commits intoMarkUsProject:masterfrom Sep 26, 2025
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 18009993361Details
💛 - Coveralls |
david-yz-liu
approved these changes
Sep 26, 2025
donny-wong
added a commit
to donny-wong/Markus
that referenced
this pull request
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
Currently by default the file viewer renders Microsoft Office files, but it should not because they are in the form of binary/compressed contents, which would be displayed as garbled data. Instead give the user the option to render these files.
Screenshots of your changes (if applicable)
Here is how it looks when the file viewer tries to render a Microsoft Word document:This is when we do not render by default but provide the user the option to do so:
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)