Skip to content

Improve the Assignment Summary page and labels#7560

Merged
david-yz-liu merged 14 commits intoMarkUsProject:masterfrom
freyazjiner:update-assignment-summary-page
Jun 12, 2025
Merged

Improve the Assignment Summary page and labels#7560
david-yz-liu merged 14 commits intoMarkUsProject:masterfrom
freyazjiner:update-assignment-summary-page

Conversation

@freyazjiner
Copy link
Member

@freyazjiner freyazjiner commented Jun 6, 2025

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)
Delete the "class average", "class median", and "# annotations per marked submission" entries in the "Status" column
in the instructor Assignments page, and replace it with a link to the assignment summary page.
Rename the "Assignment Summary" link name and the sub-tab label under the Assignment page to "Grades".

Screenshots of your changes (if applicable) image image
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots) X
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)
I am not sure if I should rename "Summary Table" and "Summary Statistics" as well.

@freyazjiner freyazjiner changed the title update Grades page and labels Improve the Assignment Summary page and labels Jun 6, 2025
@freyazjiner freyazjiner requested a review from david-yz-liu June 6, 2025 16:21
@coveralls
Copy link
Collaborator

coveralls commented Jun 6, 2025

Pull Request Test Coverage Report for Build 15592654048

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.963%

Totals Coverage Status
Change from base Build 15535308298: 0.0%
Covered Lines: 41952
Relevant Lines: 44936

💛 - Coveralls

Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freyazjiner good work, the changes are all good. In addition to the inline comment I left, please also change the title of the summary page to say "Grades: " rather than "Summary: ". Please then also update the screenshots for your Wiki PR.

Wiki Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be added. You may have cloned the Wiki repository within the MarkUs repository. In any case, you shouldn't have added it---make sure you are using git add/git commit with specific files (and not just doing git add ., for example).

@freyazjiner freyazjiner requested a review from david-yz-liu June 10, 2025 17:23
@david-yz-liu david-yz-liu merged commit e6be6ab into MarkUsProject:master Jun 12, 2025
6 checks passed
@david-yz-liu david-yz-liu mentioned this pull request Jun 12, 2025
9 tasks
@freyazjiner freyazjiner deleted the update-assignment-summary-page branch January 5, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants