Add tests to #edit and #update when user is trying to change criteria when marks have already been released#7527
Merged
david-yz-liu merged 9 commits intoMarkUsProject:masterfrom May 20, 2025
Conversation
merge is necessary to add new tests
for more information, see https://pre-commit.ci
need to reconcile divergent branches
Contributor
Author
|
Supercedes issue #7526 |
Collaborator
Pull Request Test Coverage Report for Build 15146668697Details
💛 - Coveralls |
david-yz-liu
approved these changes
May 20, 2025
Collaborator
david-yz-liu
left a comment
There was a problem hiding this comment.
@chickenwaddle77 good work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The PR adds new test coverage for the #edit and #update methods for CriteriaController. When the user is authenticated and authorised, and tries to edit/update the criteria after marks have not been released, there should be a flash message with an error, and the appropriate response code is returned. This PR adds two tests for these two methods.
...
Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)