Skip to content

Add tests to #edit and #update when user is trying to change criteria when marks have already been released#7527

Merged
david-yz-liu merged 9 commits intoMarkUsProject:masterfrom
chickenwaddle77:new-edit-update-rspec-tests
May 20, 2025
Merged

Add tests to #edit and #update when user is trying to change criteria when marks have already been released#7527
david-yz-liu merged 9 commits intoMarkUsProject:masterfrom
chickenwaddle77:new-edit-update-rspec-tests

Conversation

@chickenwaddle77
Copy link
Contributor

Proposed Changes

The PR adds new test coverage for the #edit and #update methods for CriteriaController. When the user is authenticated and authorised, and tries to edit/update the criteria after marks have not been released, there should be a flash message with an error, and the appropriate response code is returned. This PR adds two tests for these two methods.
...

Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests) X
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@chickenwaddle77 chickenwaddle77 changed the title Add tests to #edit and #update when user is trying to change criteria when marks have already been released #7526 Add tests to #edit and #update when user is trying to change criteria when marks have already been released May 20, 2025
@chickenwaddle77
Copy link
Contributor Author

Supercedes issue #7526

@chickenwaddle77 chickenwaddle77 self-assigned this May 20, 2025
@chickenwaddle77 chickenwaddle77 added ruby Pull requests that update Ruby code testing labels May 20, 2025
@coveralls
Copy link
Collaborator

coveralls commented May 20, 2025

Pull Request Test Coverage Report for Build 15146668697

Details

  • 40 of 40 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 91.951%

Totals Coverage Status
Change from base Build 15126063264: 0.01%
Covered Lines: 41937
Relevant Lines: 44923

💛 - Coveralls

Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chickenwaddle77 good work!

@david-yz-liu david-yz-liu merged commit 9cfe389 into MarkUsProject:master May 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Pull requests that update Ruby code testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants