Ensure tags are unique within an assignment#7430
Merged
david-yz-liu merged 4 commits intoMarkUsProject:masterfrom Feb 23, 2025
Merged
Ensure tags are unique within an assignment#7430david-yz-liu merged 4 commits intoMarkUsProject:masterfrom
david-yz-liu merged 4 commits intoMarkUsProject:masterfrom
Conversation
Collaborator
Pull Request Test Coverage Report for Build 13457613824Details
💛 - Coveralls |
…sssement_id is nil
Collaborator
david-yz-liu
left a comment
There was a problem hiding this comment.
@donny-wong good work, and good screenshots. In addition to the comment I left, you should use GitHub PR linking keywords to link this to the issue you created. See https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue
Changelog.md
Outdated
| - Optimized the querying of submissions when assigning graders (#7381) | ||
| - Update remote_autotest_settings_id validation to be unique to an autotester (#7393) | ||
| - Fix tag creation failing in tags table (#7426) | ||
| - Ensure tags are unique within an assignment (#7430) |
Collaborator
There was a problem hiding this comment.
Say tag names here, not just "tags"
Contributor
Author
There was a problem hiding this comment.
Thank you @david-yz-liu for these helpful comments.
david-yz-liu
approved these changes
Feb 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
We want to make tags unique within an assignment. A validation rule was added to the Tag model to ensure the name was unique to an assignment.
...
Screenshots of your changes (if applicable)
e.g:

When I tried to create another tag that already exist ("tag_1") in the same assignment, it would not permit me:
With another assignment for the same course, I was able to when this name was already used from the above assignment:

Associated documentation repository pull request (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)