Skip to content

Ensure tags are unique within an assignment#7430

Merged
david-yz-liu merged 4 commits intoMarkUsProject:masterfrom
donny-wong:tag_uniqueness_constraint
Feb 23, 2025
Merged

Ensure tags are unique within an assignment#7430
david-yz-liu merged 4 commits intoMarkUsProject:masterfrom
donny-wong:tag_uniqueness_constraint

Conversation

@donny-wong
Copy link
Contributor

@donny-wong donny-wong commented Feb 20, 2025

Proposed Changes

We want to make tags unique within an assignment. A validation rule was added to the Tag model to ensure the name was unique to an assignment.

...

Screenshots of your changes (if applicable)

e.g:
When I tried to create another tag that already exist ("tag_1") in the same assignment, it would not permit me:
duplicate constraint

With another assignment for the same course, I was able to when this name was already used from the above assignment:
successful for another assignment

Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) x
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@donny-wong donny-wong changed the title Make tag unique within an assessment Make tag unique within an assignment Feb 20, 2025
@donny-wong donny-wong changed the title Make tag unique within an assignment Ensure tags are unique within an assignment Feb 20, 2025
@coveralls
Copy link
Collaborator

coveralls commented Feb 20, 2025

Pull Request Test Coverage Report for Build 13457613824

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.863%

Totals Coverage Status
Change from base Build 13436830841: 0.0%
Covered Lines: 41403
Relevant Lines: 44388

💛 - Coveralls

Copy link
Collaborator

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donny-wong good work, and good screenshots. In addition to the comment I left, you should use GitHub PR linking keywords to link this to the issue you created. See https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

Changelog.md Outdated
- Optimized the querying of submissions when assigning graders (#7381)
- Update remote_autotest_settings_id validation to be unique to an autotester (#7393)
- Fix tag creation failing in tags table (#7426)
- Ensure tags are unique within an assignment (#7430)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Say tag names here, not just "tags"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @david-yz-liu for these helpful comments.

@donny-wong donny-wong added this to the v2.6.2 milestone Feb 21, 2025
@donny-wong donny-wong linked an issue Feb 21, 2025 that may be closed by this pull request
@david-yz-liu david-yz-liu merged commit fb88095 into MarkUsProject:master Feb 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure Tag names uniqueness within an assignment

3 participants