Symbol font module#67
Conversation
missing: tap/untap symbols phyrexian hybrids
|
i am very skeptical of manual blending mana symbols, we don't really see lag time from rendering symbols, it's going to be a hurdle for any new symbol font, and is probably going to remove if not completely overshadow the file size gain we get from condensing into a module the three main things i see visibly slow down MSE are
|
|
i'm not sure i'm even going to be able to review this its so much to fetch x.x |
|
None of your arguments convince me, but if you feel strongly about it, I'll change it. |
|
are you getting any notable performance increases? my first place to look for optimizations here would have been reducing the file size, most mana symbols are way bigger than they need to be. you cut them down to like 40x40, you don't lose any size on a 750w frame but you have about 5% of the pixels to run through the blend script |
there was a bug where, if the user would press ctrl+r while the cursor was in a text field that had entries, in it's insert symbol menu, that started with + or -, then it would prevent the user from typing the characters that were in those entries.
|
This is reviewable. Once it's merged I can start deleting redundant files in existing symbol fonts. I think it's best if I do this in another PR. |
This reverts commit 63dcb05.
This reverts commit 82a718d.
|
Yeah this branch is lost... How are we always getting the craziest bugs from github.... first the infinite number of files changed, now this... |
What slows MSE down the most are by far the blending operations. (Not because they are unoptimized, but just because they are expensive.) So I believe that for mana symbols at least, we should pre-blend everything. Now that does lead to about 5000 trybrid symbol files (with all 10 colors, snow, colorless, artifact, large and small variants). I think it's worth it, but I can be convinced otherwise.
One good option to reduce this number is to define a canonical ordering for the symbols. Right now I've rendered all combinations, so there's
W/U/Bbut alsoW/B/U,B/W/U, etc... That would divide the number by 6 if my math is correct.Also, I rotated the trybrids 180 degrees so they look more like the hybrids:

The chaos symbol had two bindings:
chaosandA. I removedAto use it for artifact mana. This breaks compatibility.For hybrid generic mana, I did
2/[WUBRG]and3/[WUBRG], but I didn't implement the[0-9]/[WUBRG]cause I'm lazy, and no-one uses these.I have yet to do a pass on the existing symbol fonts, to delete redundant files and implement the module. This may be better to do in another PR.