Rework default logic log messages by MaStr · Pull Request #278 · MaStr/batcontrol

MaStr · 2026-02-25T10:41:02Z

As stated in #275 , there are multiple occasions, where the logmessages tells "hour", but in fact it is working on 15 minutes.
That was adjusted.

In addition some odd logic messages, when having no recharge energy defined are left out.

Changeing logic messages from hour to "slots". Adding a message to show interval at the beginning of evaluation

Copilot

Pull request overview

This PR updates Batcontrol’s default logic logging to better reflect 15-minute operation (time “slots” instead of “hours”) and reduces some confusing recharge-related log output, aligning with issue #275.

Changes:

Reworded multiple default-logic debug messages from “hours” to “slots” and updated related docstrings.
Adjusted displayed evaluation-window timestamps for slot-based evaluation logging.
Added cycle-start logging in the main Batcontrol.run() loop.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File	Description
`src/batcontrol/logic/default.py`	Renames hour-based terms to slot-based terms in logs/docstrings and tweaks recharge/discharge evaluation logging behavior.
`src/batcontrol/core.py`	Adds log lines at the start of each evaluation cycle, including the configured time resolution.

src/batcontrol/logic/default.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-02-25T11:00:19Z

@MaStr I've opened a new pull request, #279, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot · 2026-02-25T11:00:26Z

@MaStr I've opened a new pull request, #280, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

src/batcontrol/logic/default.py

* Initial plan * Fix PEP8 whitespace: remove extra spaces in append(slot) call Co-authored-by: MaStr <1036501+MaStr@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: MaStr <1036501+MaStr@users.noreply.github.com>

* Initial plan * Fix last_time calculation to align to slot boundary Co-authored-by: MaStr <1036501+MaStr@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: MaStr <1036501+MaStr@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

src/batcontrol/logic/default.py

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

src/batcontrol/logic/default.py

src/batcontrol/core.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

src/batcontrol/logic/default.py

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

src/batcontrol/logic/common.py

src/batcontrol/logic/default.py

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

src/batcontrol/logic/default.py

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/batcontrol/logic/default.py:422

After computing recharge_energy = required_energy - stored_usable_energy, the code no longer short-circuits when recharge_energy <= 0. That means a negative/zero recharge_energy flows into the free-capacity/min-threshold logic and can trigger the "below threshold" debug message even though no charging is needed. Add an early return (and/or a dedicated debug message) when recharge_energy <= 0.0 to keep logs and control flow consistent with the intended meaning.

        free_capacity = calc_input.free_capacity

        if recharge_energy > free_capacity:
            recharge_energy = free_capacity
            logger.debug(

src/batcontrol/logic/common.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

MaStr added 5 commits February 25, 2026 11:17

Fixing wrong debug msg: "hour"

8aab194

Changeing logic messages from hour to "slots". Adding a message to show interval at the beginning of evaluation

Changing more messages hours -> slots

bc8c8b4

Update docstring to replace "high price hours" with "high price slots"

ace0fba

Get rid of excessive recharge below threshold mesage

d683014

Fix refactor mistake

9aa1ed7

MaStr self-assigned this Feb 25, 2026

Copilot AI review requested due to automatic review settings February 25, 2026 10:41

Copilot started reviewing on behalf of MaStr February 25, 2026 10:41 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

Update src/batcontrol/logic/default.py

61140a8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 25, 2026 10:59

MaStr and others added 2 commits February 25, 2026 11:59

Update src/batcontrol/logic/default.py

00059ad

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/batcontrol/logic/default.py

9dae4c1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of MaStr February 25, 2026 11:00 View session

Copilot AI mentioned this pull request Feb 25, 2026

Fix PEP8 whitespace: remove extra spaces in parentheses #279

Merged

Update src/batcontrol/logic/default.py

0b851e5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI mentioned this pull request Feb 25, 2026

Fix slot boundary alignment for evaluation window end-time log #280

Merged

Copilot AI reviewed Feb 25, 2026

View reviewed changes

src/batcontrol/logic/default.py Show resolved Hide resolved

src/batcontrol/logic/default.py Outdated Show resolved Hide resolved

src/batcontrol/logic/default.py Outdated Show resolved Hide resolved

src/batcontrol/logic/default.py Show resolved Hide resolved

Copilot AI and others added 2 commits February 25, 2026 12:27

Copilot AI review requested due to automatic review settings February 25, 2026 11:28

Copilot started reviewing on behalf of MaStr February 25, 2026 11:28 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

src/batcontrol/logic/default.py Outdated Show resolved Hide resolved

src/batcontrol/logic/default.py Outdated Show resolved Hide resolved

src/batcontrol/logic/default.py Outdated Show resolved Hide resolved

MaStr added 2 commits February 25, 2026 12:32

Add feedback

dbdf0ca

Use singal slot in loop over plural form

193c559

Copilot AI review requested due to automatic review settings February 25, 2026 11:33

Copilot started reviewing on behalf of MaStr February 25, 2026 11:34 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

src/batcontrol/logic/default.py Show resolved Hide resolved

src/batcontrol/core.py Outdated Show resolved Hide resolved

Update src/batcontrol/core.py

5d207d8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 25, 2026 11:39

Copilot started reviewing on behalf of MaStr February 25, 2026 11:39 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

src/batcontrol/logic/default.py Show resolved Hide resolved

MaStr added 2 commits February 25, 2026 12:44

remove entry message on run()

fac3bf8

Some other cleanups and formatting issues

e68b0d7

MaStr requested a review from Copilot February 25, 2026 12:02

Copilot started reviewing on behalf of MaStr February 25, 2026 12:02 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

Review Feedack added

32a1320

MaStr requested a review from Copilot February 25, 2026 12:12

Copilot started reviewing on behalf of MaStr February 25, 2026 12:12 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

src/batcontrol/logic/default.py Outdated Show resolved Hide resolved

Review feedback

2376292

MaStr requested a review from Copilot February 25, 2026 12:23

Copilot started reviewing on behalf of MaStr February 25, 2026 12:23 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

src/batcontrol/logic/common.py Outdated Show resolved Hide resolved

Update src/batcontrol/logic/common.py

1713880

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings February 25, 2026 12:29

Copilot started reviewing on behalf of MaStr February 25, 2026 12:30 View session

Copilot AI reviewed Feb 25, 2026

View reviewed changes

MaStr merged commit f25d7e6 into main Feb 25, 2026
17 checks passed

MaStr deleted the issue-275 branch February 25, 2026 12:42

Conversation

MaStr commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Feb 25, 2026

Uh oh!

Copilot AI commented Feb 25, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants