Add Unit Tests for Tonal Extractor and Improvements in ReplayGain,VectorRealToTensor and HarmonicBpm #1496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces several improvements, mainly focused on testing and minor bug fixes across the audio processing algorithms:
Summary of changes included:
-Tonal Extractor Unit Tests
-Added initial unit tests for the Tonal Extractor algorithm.
-Extended tests to use real audio data for more robust QA.
-Fixed spelling errors in comments within test files.
Details:
-ReplayGain Fix : Removed a warning in the ReplayGain destructor.
-Added unit tests for the ReplayGain module.
File affected: test/src/unittests/standard/test_replaygain.py
Code changes in: src/algorithms/standard/replaygain.cpp
-Minor Algorithm Fix: Corrected initialization of bestBpm in HarmonicBpm::findHarmonicBpms.
Files affected: src/algorithms/rhythm/harmonicbpm.cpp
-Fixed type casting in VectorRealToTensor::process for better type safety.
Files affected:src/algorithms/standard/vectorrealtotensor.cpp
Impact:
Strengthens test coverage for tonal extraction and replay gain calculations.
Improves code safety and reduces runtime warnings.
No breaking changes expected.
Notes:
This PR merges previous updates from MTG:master to ensure alignment with the main branch