Heat equation smoothing of IC#805
Merged
sbryngelson merged 12 commits intoMFlowCode:masterfrom Mar 10, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #805 +/- ##
==========================================
- Coverage 43.94% 43.65% -0.29%
==========================================
Files 65 65
Lines 19039 19157 +118
Branches 2329 2338 +9
==========================================
- Hits 8366 8363 -3
- Misses 9262 9370 +108
- Partials 1411 1424 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sbryngelson
requested changes
Mar 7, 2025
Member
sbryngelson
left a comment
There was a problem hiding this comment.
+700 lines for just this one feature? is there anyway to trim this down?
sbryngelson
reviewed
Mar 7, 2025
sbryngelson
reviewed
Mar 7, 2025
sbryngelson
reviewed
Mar 7, 2025
Contributor
Author
|
@sbryngelson, I've addressed your comments. Now that I've modified code in |
sbryngelson
approved these changes
Mar 10, 2025
mrodrig6
added a commit
to ComputationalFlowGroup/MFC
that referenced
this pull request
Mar 13, 2025
Reviewed and approved resolved conflicts. Passes test suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds heat equation smoothing for ICs.
Type of change
Please delete options that are not relevant.
Scope
How Has This Been Tested?
The following figures show a bunch of smoothing configurations, with black borders denoting processor boundaries:
The following examples were ran on Wingtip with 64 CPU ranks:
Checklist
docs/)./mfc.sh formatbefore committing my codeIf your code changes any code source files (anything in
src/simulation)To make sure the code is performing as expected on GPU devices, I have:
The following shows strong and weak scaling on Frontier with and without RDMA mpi. Strong scaling was done with a 64m grid cell

3D_performance_testand starts at two ranks and ends at 32 ranks. Weak scaling was done with 8m grid cells per GPU using the same case file, beginning at two ranks and ending at 32 ranks.