Revert "Fix hypoelastic instability"#776
Merged
sbryngelson merged 4 commits intomasterfrom Dec 27, 2024
Merged
Conversation
This reverts commit 630695c.
sbryngelson
requested review from
ChrisZYJ
and removed request for
henryleberre
20 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #776 +/- ##
==========================================
+ Coverage 43.72% 43.79% +0.07%
==========================================
Files 65 65
Lines 19053 19056 +3
Branches 2319 2326 +7
==========================================
+ Hits 8331 8346 +15
+ Misses 9320 9302 -18
- Partials 1402 1408 +6 ☔ View full report in Codecov by Sentry. |
ChrisZYJ
reviewed
Dec 26, 2024
src/simulation/m_hypoelastic.fpp
Outdated
|
|
||
| use m_finite_differences | ||
| use m_helper | ||
| use m_mpi_proxy !< Message passing interface (MPI) module proxy |
Contributor
There was a problem hiding this comment.
Could we please remove the use m_mpi_proxy line? I think it wasn't present in the previous version.
Contributor
|
Yes this is exactly what I meant. I made one comment but don't think it matters. Really sorry for the trouble! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #773