Add modular precision

[aricer123]

Description

Draft for adding modern and modular precision, replaces instances of kind(0d0) and MPI_DOUBLE_PRECISION with a constant declared in the common/ directory

Fixes #42

[sbryngelson]

What about all the _d0 or _0d0 statements?

[aricer123]

What about all the _d0 or _0d0 statements?

working on those next
Why is it failing on the GPUs? Is this happening with other PRs too?

[sbryngelson]

I'm not sure, to be honest. I will check back tomorrow.

But, other PRs seem to be fine (I merged some recently).

[codecov]

Codecov Report

Attention: Patch coverage is 49.09945% with 650 lines in your changes missing coverage. Please review.

Project coverage is 54.69%. Comparing base (3cf7fb6) to head (298014f).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
src/pre_process/m_patches.fpp	15.15%	136 Missing and 4 partials ⚠️
src/simulation/m_data_output.fpp	21.73%	54 Missing ⚠️
src/simulation/m_rhs.fpp	21.31%	48 Missing ⚠️
src/common/m_eigen_solver.f90	40.62%	23 Missing and 15 partials ⚠️
src/simulation/m_bubbles.fpp	46.77%	27 Missing and 6 partials ⚠️
src/pre_process/m_assign_variables.f90	20.00%	32 Missing ⚠️
src/post_process/m_derived_variables.fpp	0.00%	28 Missing ⚠️
src/common/m_variables_conversion.fpp	58.82%	21 Missing ⚠️
src/post_process/m_mpi_proxy.fpp	20.00%	20 Missing ⚠️
src/pre_process/m_check_patches.fpp	0.00%	20 Missing ⚠️
... and 25 more

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #626   +/-   ##
=======================================
  Coverage   54.69%   54.69%           
=======================================
  Files          59       59           
  Lines       13662    13662           
  Branches     1698     1698           
=======================================
  Hits         7473     7473           
  Misses       5740     5740           
  Partials      449      449           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sbryngelson]

Did you read the log in the failing CI run?

 Generating case.fpp.
   Writing a (new) custom case.fpp file.
 $ cmake --build /storage/scratch1/6/sbryngelson3/runners/actions-runner-3/_work/MFC/MFC/build/staging/ea58b6820d --target syscheck --parallel 8 --config Release

[ 25%] Preprocessing (Fypp) syscheck.fpp
[ 50%] Building Fortran object CMakeFiles/syscheck_lib.dir/fypp/syscheck/syscheck.fpp.f90.o
NVFORTRAN-S-0087-Non-constant expression where constant expression required (/storage/scratch1/6/sbryngelson3/runners/actions-runner-3/_work/MFC/MFC/src/syscheck/syscheck.fpp: 56)
NVFORTRAN-S-0081-Illegal selector - KIND parameter has unknown value for data type  (/storage/scratch1/6/sbryngelson3/runners/actions-runner-3/_work/MFC/MFC/src/syscheck/syscheck.fpp: 56)
  0 inform,   0 warnings,   2 severes, 0 fatal for syscheck
gmake[3]: *** [CMakeFiles/syscheck_lib.dir/build.make:80: CMakeFiles/syscheck_lib.dir/fypp/syscheck/syscheck.fpp.f90.o] Error 2
gmake[2]: *** [CMakeFiles/Makefile2:111: CMakeFiles/syscheck_lib.dir/all] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:92: CMakeFiles/syscheck.dir/rule] Error 2
gmake: *** [Makefile:170: syscheck] Error 2

[sbryngelson]

@wilfonba per your request

[aricer123]

Looks like its only failing formatting.
Any tips to pass @henryleberre? I haven't seen this one before.

[sbryngelson]

@aricer123 have you read the code documentation on the website?

[aricer123]

@aricer123 have you read the code documentation on the website?

Yes I have taken a look at it but I still can't figure out why this would fail the formatting test. I don't recall changing anything else in the file which is currently failing but I will take a closer look and let you know.

[sbryngelson]

./mfc.sh format

[aricer123]

done

[sbryngelson]

@arciyer123 @aricer123 this PR is ready to merge?

[henryleberre]

@sbryngelson Looks like my latest PR is the source of a lot of conflicts.

[sbryngelson]

@sbryngelson Looks like my latest PR is the source of a lot of conflicts.

I know, that's ok. It was a rhetorical question.

[aricer123]

Formatting is done and it should pass but still need to resolve the conflicts.
Should be ready to merge after next commit.

[aricer123]

Having issues with the merge since it's making me do it manually
Looks like somehow i screwed up my working branch while trying to do it.
Do you guys have any tips to resolve these conflicts in a cleaner way?