You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I also took this opportunity to make mfc.sh print what it does and detect when the CMake binary it sometimes has to download becomes incompatible (and downloads CMake again). It also extracts the required CMake version from CMakeLists.txt at runtime.
@sbryngelson There currently is no support for running CI pipelines on GitLab for Pull Requests originating from forks on GitHub (see discussion here). This is why the ORNL pipeline is not running.
The issue I fixed in #18 was actually related to the fact that I was using the commit ref's slug (instead of its name) when running git clone -b <ref> <URL> in the pipeline. I had first thought that the Pull Request was made from the (external) MFC-develop repository but I was wrong. It was a subtle issue because it only fails when the ref (commit name, tag, etc..) is contains certain characters (like capital letters and spaces). Here are the details:
CI_COMMIT_REF_SLUG: CI_COMMIT_REF_NAME in lowercase, shortened to 63 bytes, and with everything except 0-9 and a-z replaced with -. No leading / trailing -. Use in URLs, host names and domain names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugSomething isn't working or doesn't seem rightenhancementNew feature or request
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request
cmakebuild from binary issues #20./mfc.shbuilds python packages forvenvon first launch without letting the user know #23pre_process_code, ...? #24I also took this opportunity to make
mfc.shprint what it does and detect when the CMake binary it sometimes has to download becomes incompatible (and downloads CMake again). It also extracts the required CMake version fromCMakeLists.txtat runtime.