Skip to content

Fix Docker build on ARM by pre-installing numpy #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbryngelson merged 4 commits into from
Feb 4, 2026
Merged

Fix Docker build on ARM by pre-installing numpy #1121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24a3063
Fix Docker build on ARM by pre-installing numpy
sbryngelson Feb 3, 2026
85fb909
Fix Docker workflow to clone from current repository
sbryngelson Feb 3, 2026
50a3a24
Move numpy pre-install from python.sh to Dockerfile
sbryngelson Feb 3, 2026
8fec7ad
Update Docker to Python 3.12 for pyrometheus compatibility
sbryngelson Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,17 +15,17 @@ RUN apt-get update -y && \
if [ "$TARGET" != "gpu" ]; then \
apt-get install -y \
build-essential git make cmake gcc g++ gfortran bc \
python3.11 python3.11-venv python3-pip \
python3.12 python3.12-venv python3-pip \
openmpi-bin libopenmpi-dev libfftw3-dev \
mpich libmpich-dev; \
else \
apt-get install -y \
build-essential git make cmake bc \
python3.11 python3.11-venv python3-pip \
python3.12 python3.12-venv python3-pip \
libfftw3-dev \
openmpi-bin libopenmpi-dev; \
fi && \
update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.11 2 && \
update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.12 2 && \
rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

ENV OMPI_ALLOW_RUN_AS_ROOT=1
Expand All @@ -40,6 +40,13 @@ ENV FC=${FC_COMPILER}
ENV PATH="${COMPILER_PATH}:$PATH"
ENV LD_LIBRARY_PATH="${COMPILER_LD_LIBRARY_PATH}:${LD_LIBRARY_PATH:-}"

# Pre-install numpy into the venv before mfc.sh runs, as it's required at
# build time by several dependencies (pandas, cantera, matplotlib, etc.) that
# may need to compile from source on architectures without pre-built wheels
RUN python3.12 -m venv /opt/MFC/build/venv && \
/opt/MFC/build/venv/bin/pip install --upgrade pip && \
/opt/MFC/build/venv/bin/pip install numpy

RUN echo "TARGET=$TARGET CC=$CC_COMPILER FC=$FC_COMPILER" && \
cd /opt/MFC && \
if [ "$TARGET" = "gpu" ]; then \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
TAG="${{ github.event.inputs.tag || github.ref_name }}"
echo "tag=$TAG" >> $GITHUB_OUTPUT
echo "TAG=$TAG" >> $GITHUB_ENV
git clone --branch "$TAG" --depth 1 https://github.com/MFlowCode/MFC.git mfc
git clone --branch "$TAG" --depth 1 ${{ github.server_url }}/${{ github.repository }}.git mfc

- name: Stage
run: |
Expand Down