Support keyboard trigger in wayland capture #2568
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
CI gfxreconstruct build queued with queue ID 603484. |
Collaborator
|
CI gfxreconstruct build # 8368 running. |
Collaborator
|
CI gfxreconstruct build # 8368 passed. |
Contributor
Author
|
Need to add more error handling and fix some issues described by some users who I asked for advice on creating this PR. |
Were missing and prevent easy 'resetting' using assignment of default constructed WaylandLoader.
Requires adding PreProcess_vkDestroySurfaceKHR in order to cleanup created wayland objects created during vkCreateWaylandSurfaceKHR.
charles-lunarg
force-pushed
the
support_keyboard_trigger_in_wayland_capture
branch
from
f74314f to
810ec2d
Compare
Collaborator
|
CI gfxreconstruct build queued with queue ID 608251. |
Collaborator
|
CI gfxreconstruct build # 8428 running. |
Collaborator
|
CI gfxreconstruct build # 8428 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.