Correct differing function definitions #2531
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the d3d12/dxgi dll_main.cpp files, these release-capture functions have WINAPI in their definition, but they do not elsewhere. Adding WINAPI elsewhere to fix the conflict, which causes exceptions in x86
Collaborator
|
Author ryannecas not on autobuild list. Waiting for curator authorization before starting CI build. |
Collaborator
|
CI gfxreconstruct build queued with queue ID 599278. |
Collaborator
|
CI gfxreconstruct build # 8336 running. |
Collaborator
|
CI gfxreconstruct build # 8336 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the d3d12/dxgi dll_main.cpp files, these release-capture functions have WINAPI in their definition, but they do not elsewhere. Adding WINAPI elsewhere to fix the conflict, which causes exceptions in x86