Open
Conversation
zNotChill
reviewed
May 13, 2025
|
|
||
| @TwineNativeFunction | ||
| override fun toString(): String { | ||
| return "AABB($minProperty, $maxProperty)" |
Contributor
There was a problem hiding this comment.
styling issue, should reflect the name of the class,
class LuaAABBs : TwineNative("aabb") {
should then be return "aabb($minProperty, $maxProperty)"
not a major issue though
zNotChill
requested changes
May 13, 2025
Contributor
zNotChill
left a comment
zNotChill
left a comment
There was a problem hiding this comment.
LGTM, but lacks unit tests. Please add them!
You can see how the tests work here:
https://github.com/LuaRocket/rocket/tree/main/src/test/kotlin/dev/znci/rocket/scripting/globals/tables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find that bounding boxes fit with the theme of adding Vectors aswell.