Skip to content

Conversation

@cerqiest
Copy link
Collaborator

No description provided.

@cerqiest cerqiest requested a review from zNotChill as a code owner April 19, 2025 05:37
@github-actions
Copy link

github-actions bot commented Apr 19, 2025

Qodana Community for JVM

44 new problems were found

Inspection name Severity Problems
Unused symbol 🔶 Warning 19
Unused import directive 🔶 Warning 4
Unresolved reference in KDoc 🔶 Warning 2
Redundant call of conversion method 🔶 Warning 2
Redundant qualifier name 🔶 Warning 2
Constant conditions 🔶 Warning 1
Redundant nullable return type 🔶 Warning 1
Class member can have 'private' visibility ◽️ Notice 5
If-Null return/break/... foldable to '?:' ◽️ Notice 2
Redundant lambda arrow ◽️ Notice 2
Condition of 'if' expression is constant ◽️ Notice 1
Variable declaration could be moved inside 'when' ◽️ Notice 1
Redundant empty primary constructor ◽️ Notice 1
Accessor call that can be replaced with property access syntax ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link
Contributor

@zNotChill zNotChill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good mostly

@cerqiest cerqiest requested a review from zNotChill April 19, 2025 05:44
Copy link
Contributor

@zNotChill zNotChill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but don't merge until I have tested

@zNotChill zNotChill merged commit ad7817e into twine-api Apr 19, 2025
2 of 3 checks passed
@cerqiest cerqiest deleted the twine-api-server branch April 19, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants