Skip to content

New API#29

Merged
gibbiemonster merged 22 commits intomainfrom
new-api
Apr 8, 2025
Merged

New API#29
gibbiemonster merged 22 commits intomainfrom
new-api

Conversation

@gibbiemonster
Copy link
Contributor

Mostly the work of @zNotChill.

Add a new way of interfacing with Lua, primarily using Kotlin-Reflect, to make things easier on the DevEx side, and allow for the possibility of third-party plugins down the line. There are still some kinks that need worked out - however this is a good starting point and will not dig us a hole like LuaTable currently is.

Still TODO: Developer docs. @cerqiest should be writing these soon, once this is merged.

@gibbiemonster gibbiemonster requested a review from zNotChill as a code owner April 4, 2025 20:40
zNotChill
zNotChill previously approved these changes Apr 5, 2025
Copy link
Contributor

@zNotChill zNotChill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it still isn't ready since some things are still using the old API. I will take the responsibility of updating this tomorrow

zNotChill
zNotChill previously approved these changes Apr 5, 2025
@gibbiemonster gibbiemonster marked this pull request as draft April 5, 2025 13:34
@gibbiemonster gibbiemonster marked this pull request as ready for review April 8, 2025 11:42
@gibbiemonster
Copy link
Contributor Author

Enums are still WIP. Waiting for status checks and builds to complete before merge.

@github-actions
Copy link

github-actions bot commented Apr 8, 2025

Qodana Community for JVM

42 new problems were found

Inspection name Severity Problems
Usage of redundant or deprecated syntax or deprecated symbols 🔶 Warning 33
Unused symbol 🔶 Warning 6
Class member can have 'private' visibility ◽️ Notice 2
Condition of 'if' expression is constant ◽️ Notice 1

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@gibbiemonster gibbiemonster marked this pull request as draft April 8, 2025 12:03
@gibbiemonster gibbiemonster marked this pull request as ready for review April 8, 2025 12:04
@gibbiemonster gibbiemonster merged commit 3edb6bc into main Apr 8, 2025
3 checks passed
@cerqiest cerqiest deleted the new-api branch April 19, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants