Skip to content

fix: random qodana issues. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gibbiemonster merged 1 commit into from
Mar 15, 2025
Merged

fix: random qodana issues. #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/kotlin/dev/znci/rocket/scripting/PermissionsManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ object PermissionsManager {
return player.hasPermission("group.$group")
}

@Suppress("unused") // TODO: This will be used in the future. Remove this decorator when it's used.
fun getPlayerGroups(player: Player): List<String> {
return player.effectivePermissions
.filter { it.permission.startsWith("group.") }
Expand Down
6 changes: 4 additions & 2 deletions src/main/kotlin/dev/znci/rocket/scripting/ScriptManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,16 +26,18 @@ import org.luaj.vm2.lib.jse.JsePlatform
import java.util.ArrayList

object ScriptManager {
var scriptsFolder: File = File("")
val globals: Globals = JsePlatform.standardGlobals()
private val globals: Globals = JsePlatform.standardGlobals()

var scriptsFolder: File = File("")
val usedEvents = mutableMapOf<Class<out Event>, LuaValue>()
val enabledCommands = mutableMapOf<String, Command>()

@Suppress("unused") // TODO: Will be used in the future when custom configuration folders are implemented
fun setFolder(folder: File) {
scriptsFolder = folder
}

@Suppress("unused") // TODO: Is this still required?
fun loadScripts() {
scriptsFolder.walkTopDown().forEach { file ->
if (file.isFile && !file.startsWith("-")) {
Expand Down
4 changes: 2 additions & 2 deletions src/main/kotlin/dev/znci/rocket/scripting/events/EventListener.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,8 @@ import dev.znci.rocket.scripting.ScriptManager
import org.bukkit.Bukkit
import org.bukkit.event.Cancellable
import org.bukkit.event.Event
import org.bukkit.event.EventHandler
import org.bukkit.event.EventPriority
import org.bukkit.event.Listener
import org.bukkit.event.block.BlockBreakEvent
import org.bukkit.plugin.Plugin
import org.luaj.vm2.LuaBoolean
import org.luaj.vm2.LuaTable
Expand Down Expand Up @@ -133,6 +131,7 @@ object EventListener : Listener {
val fromField = event.javaClass.getDeclaredField("from")
fromField.isAccessible = true
val from = fromField.get(event)
@Suppress("ControlFlowWithEmptyBody") // Remove this when implementing
if (from is org.bukkit.Location) {
// TODO: Finish this when mibers creates PR which adds new location class
}
Expand All @@ -142,6 +141,7 @@ object EventListener : Listener {
val toField = event.javaClass.getDeclaredField("to")
toField.isAccessible = true
val to = toField.get(event)
@Suppress("ControlFlowWithEmptyBody") // Remove this when implementing
if (to is org.bukkit.Location) {
// TODO: Finish this when mibers creates PR which adds new location class
}
Expand Down
1 change: 0 additions & 1 deletion src/main/kotlin/dev/znci/rocket/scripting/functions/Commands.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import dev.znci.rocket.scripting.PlayerManager
import dev.znci.rocket.scripting.ScriptManager
import dev.znci.rocket.scripting.util.defineProperty
import dev.znci.rocket.util.MessageFormatter
import net.kyori.adventure.text.Component
import org.bukkit.Bukkit
import org.bukkit.command.Command
import org.bukkit.command.CommandExecutor
Expand Down
Loading