Conversation
for some reason the command execution doesn't go through the commandReference.executor even though it should, which means none of this works. odd. will try to fix tomorrow I guess
Still needs polishing, aliases need adding too. Gotta sleep though
…sages & global formatter
Qodana Community for JVM9 new problems were found
☁️ View the detailed Qodana report Contact Qodana teamContact us at qodana-support@jetbrains.com
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes command handler messages by correcting color formatting and adding a new custom permission message along with a global message formatter.
- Fixed usage and permission messages to use the correct color formatting symbol.
- Added a custom permission message entry in the locale file ("no_permission").
gibbiemonster
requested changes
Mar 15, 2025
Contributor
gibbiemonster
left a comment
gibbiemonster
left a comment
There was a problem hiding this comment.
LGTM, but please address qodana new issues.
Before, it would always send the usage message, but now there is an argCount, it works *mostly* as intended. Also updated the en_GB locale
gibbiemonster
approved these changes
Mar 15, 2025
Contributor
gibbiemonster
left a comment
gibbiemonster
left a comment
There was a problem hiding this comment.
Nitpicking 🙂
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds/fixes:
§->&)MessageFormatter)no_permission