Added more support for LuaLocation features.#15
Merged
zNotChill merged 9 commits intoLuaRocket:mainfrom Mar 10, 2025
miberss:main
Merged
Added more support for LuaLocation features.#15zNotChill merged 9 commits intoLuaRocket:mainfrom miberss:main
zNotChill merged 9 commits intoLuaRocket:mainfrom
miberss:main
Conversation
Contributor
Author
|
I'm actually gonna remake this to use world UUID's so we can have serialization in the future; I would rather not get it merged right now |
Contributor
Author
|
This is a lot than the PR expected but I am bad at git and don't know how to split it into two. It is now ready to be merged. |
zNotChill
reviewed
Mar 10, 2025
zNotChill
reviewed
Mar 10, 2025
zNotChill
requested changes
Mar 10, 2025
Contributor
zNotChill
left a comment
zNotChill
left a comment
There was a problem hiding this comment.
Looks good to me (works in my own testing) however some new files lack licensing comments.
Contributor
|
ignore qodana failures. Branch is out of sync 🙂 |
zNotChill
approved these changes
Mar 10, 2025
Contributor
zNotChill
left a comment
zNotChill
left a comment
There was a problem hiding this comment.
Perfect. Ready for merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locations weren't that useful and also had some bugs so I re-implemented locations to the existing classes and added optional worlds, yaw and pitch, and teleportation.
I created testing for this syntax here.
LuaLocation-test.txt