Add CAGE and IAGE to reorganized and updated settings view #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test✅ Successful test DetailsBuilt this version over an existing instance of Loop that was connected to an MDT 515 pump on an SE phone running iOS 18.7.2 Initially the 2 rows are not visible, as expected. Did a fixed prime (as if changing cannula).
Did a rewind (as if changing the reservoir)
|
Contributor
Test with different hardware✅ Successfully repeated the test with an SE phone running iOS 26.2 and an MDT 523 pump. |
marionbarker
approved these changes
Dec 21, 2025
Contributor
marionbarker
left a comment
marionbarker
left a comment
There was a problem hiding this comment.
Approved by Test.
Code review appeared reasonable.
ps2
approved these changes
Dec 23, 2025
Contributor
ps2
left a comment
ps2
left a comment
There was a problem hiding this comment.
LGTM. Just a comment about using frameworkImage.
| .fill(fillColor) | ||
| .mask( | ||
| Image("reservoir_mask") | ||
| Image("reservoir_mask", bundle: Bundle(for: MinimedPumpSettingsViewModel.self)) |
Contributor
There was a problem hiding this comment.
We also have a helper for this:
Image(frameworkImage: "reservoir_mask")
Contributor
Final TestI tested again with the updated syntax. It still works as expected for both Loop and Trio. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Cannula AgeandInsulin Ageto the Minimed Settings View, to allow users to more easily see how long it's been since they've changed their infusion set and reservoir. The names and triggers are the same as those used to update CAGE and IAGE on Nightscout.The lines will not appear in the view until a pump event triggers its update, so if you use steel cannulas and never issue a fixed prime, Cannula Age will never update or appear. Keep this in mind when testing, as you must issue a fixed prime (cannula fill) and/or rewind from the pump after building this PR in order for these lines to appear.
This PR also fixes issues with iOS 26, which did not display the Navigation Title (ie: Medtronic 723) at the top of the sheet, and did not display the Reservoir icon under
Insulin Remaining.It also reorganizes the Settings view and adds section titles to make things viewed/accessed more often at the top, and decreases the size of the pump image by a third.
Screenshots taken on an in-vivo iPhone 14 Pro Max running iOS 26.2 with this PR inside Trio v0.6.0.26:
