Package rpm (Fedora, CentOS, RedHat)

[ReenigneArcher]

Sunshine does not currently have a method to package rpm.

If you have experience with packaging rpm and would like to contribute a PR would be very appreciated!

Edit: Should we consider using CPack? https://cmake.org/cmake/help/latest/module/CPack.html
Here is an example: https://github.com/docopt/docopt.cpp/blob/6f5de76970be94a6f1e4556d1716593100e285d2/CMakeLists.txt#L136

[GeoDerp]

Attempted to build rpms via OBS (openSUSE Build Service)

As talked about here: loki-47-6F-64/sunshine#317 (comment)

However, I came to have a few issues, openSUSE has a boost dependency issue.
And Fedora tried to build, but resulted in a few c11 issues (looks related to ffmpeg encoders).

I believe the rpm package could work, however I have not enough knowledge in cmake to fix the Fedora issue.
The openSUSE dependencie issue seems to be a repentance of an issue people have had in the past (possibly fixed in Fedora's boost-static). This may be resulted automatically with boost updates, could be a problem with the cmake process, or could be fixed by making a custom boost depedencie in the poeject for the rpm to build with.

Feel free to use this spec file as a jumping off point for future work on this issue.

Thanks,
John Whately

[ReenigneArcher]

@GeoDerp Thanks for looking into this issue! Once we resolve it I think it will be a valuable addition to Sunshine. Tried looking at the logs but not sure exactly where to see the details.

I see the run history here: https://build.opensuse.org/packages/Sunshine/job_history/home:GeoDerp:Sunshine/Fedora_35/x86_64

But no logs. Do I need to be logged in to opensuse?

Also, what exactly is opensuse? Ideally we could create the rpm using github actions as part of the create_package.yml... Fedora already being built using that. If we can package it there, the asset would be automatically uploaded with our automated release as well.

[GeoDerp]

Fedora 35:

[  143s] /usr/bin/ranlib libenet.a
[  143s] /usr/bin/ranlib libminiupnpc.a
[  143s] gmake[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/sunshine-v0.11.1.r0.ge4c9c29/redhat-linux-build'
[  143s] [ 43%] Built target enet
[  143s] gmake[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/sunshine-v0.11.1.r0.ge4c9c29/redhat-linux-build'
[  143s] [ 43%] Built target libminiupnpc-static
[  146s] cc1: some warnings being treated as errors
[  146s] gmake[2]: *** [third-party/cbs/CMakeFiles/cbs.dir/build.make:107: third-party/cbs/CMakeFiles/cbs.dir/cbs_av1.c.o] Error 1
[  149s] cc1: some warnings being treated as errors
[  150s] gmake[2]: *** [third-party/cbs/CMakeFiles/cbs.dir/build.make:93: third-party/cbs/CMakeFiles/cbs.dir/cbs_h2645.c.o] Error 1
[  150s] gmake[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/sunshine-v0.11.1.r0.ge4c9c29/redhat-linux-build'
[  150s] gmake[1]: *** [CMakeFiles/Makefile2:237: third-party/cbs/CMakeFiles/cbs.dir/all] Error 2
[  150s] gmake[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/sunshine-v0.11.1.r0.ge4c9c29/redhat-linux-build'
[  150s] gmake: *** [Makefile:94: all] Error 2
[  150s] error: Bad exit status from /var/tmp/rpm-tmp.cSjTBj (%build)

Fedora Rawhide:

[   93s] [ 38%] Linking C static library libminiupnpc.a
[   93s] cd /home/abuild/rpmbuild/BUILD/sunshine-v0.11.1.r0.ge4c9c29/redhat-linux-build/third-party/miniupnp/miniupnpc && /usr/bin/cmake -P CMakeFiles/libminiupnpc-static.dir/cmake_clean_target.cmake
[   93s] cd /home/abuild/rpmbuild/BUILD/sunshine-v0.11.1.r0.ge4c9c29/redhat-linux-build/third-party/miniupnp/miniupnpc && /usr/bin/cmake -E cmake_link_script CMakeFiles/libminiupnpc-static.dir/link.txt --verbose=1
[   93s] /usr/bin/ar qc libminiupnpc.a CMakeFiles/libminiupnpc-static.dir/igd_desc_parse.c.o CMakeFiles/libminiupnpc-static.dir/miniupnpc.c.o CMakeFiles/libminiupnpc-static.dir/minixml.c.o CMakeFiles/libminiupnpc-static.dir/minisoap.c.o CMakeFiles/libminiupnpc-static.dir/minissdpc.c.o CMakeFiles/libminiupnpc-static.dir/miniwget.c.o CMakeFiles/libminiupnpc-static.dir/upnpcommands.c.o CMakeFiles/libminiupnpc-static.dir/upnpdev.c.o CMakeFiles/libminiupnpc-static.dir/upnpreplyparse.c.o CMakeFiles/libminiupnpc-static.dir/upnperrors.c.o CMakeFiles/libminiupnpc-static.dir/connecthostport.c.o CMakeFiles/libminiupnpc-static.dir/portlistingparse.c.o CMakeFiles/libminiupnpc-static.dir/receivedata.c.o CMakeFiles/libminiupnpc-static.dir/addr_is_reserved.c.o
[   93s] /usr/bin/ranlib libminiupnpc.a
[   93s] gmake[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/sunshine-v0.11.1.r0.ge4c9c29/redhat-linux-build'
[   93s] [ 38%] Built target libminiupnpc-static
[   93s] gmake[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/sunshine-v0.11.1.r0.ge4c9c29/redhat-linux-build'
[   93s] gmake: *** [Makefile:94: all] Error 2
[   93s] error: Bad exit status from /var/tmp/rpm-tmp.vfinwL (%build)

---

But no logs. Do I need to be logged in to opensuse?

you should be able to view the spec file and also click the "failed" button here under each repo to view there logs: https://build.opensuse.org/package/show/home:GeoDerp:Sunshine/Sunshine

however, for a shortcut, here's the link to the Fedora's:

Fedora 35: https://build.opensuse.org/package/live_build_log/home:GeoDerp:Sunshine/Sunshine/Fedora_35/x86_64

Fedora Rawhide: https://build.opensuse.org/package/live_build_log/home:GeoDerp:Sunshine/Sunshine/Fedora_Rawhide/x86_64

Also, what exactly is opensuse?

Simple answer, imagine Fedora but German (by SUSE). They run things very similarly to RedHat (use rpm's however use Zypper instead of DNF) and I'm my option they trade blows with pros and cons in the workstation space. Both big names in Linux and possibly primary competitors of each other. https://www.opensuse.org/

I personally am using Fedora, and the Fedora package is way further in working. So I would recommend getting that working first. Then we can have a look at this weird boost dependencie issue of openSUSE. OBS (openSUSE build Service) is a cloud service for maintaining and creating RPM's, they also allow you to add custom variables in place to support building for diffrent Linux distributions. You can also download the project's repo locally and have that supply updates for you. Also, for my case, can input a _service file to tell OBS to pull the latest version of the git repo before build. AKA, it's quite nice.

Ideally we could create the rpm using github actions as part of the create_package.yml...
This is also a good idea, for me, building and testing in OBS works really well, however that doesn't stop you from then exporting all the work in OBS to get it to be done in github actions once you know the spec file works for the Linux distributions.

one note: I have been building it without cuda, I dont know if you want to build with or have an option for one with and one without

I'm doing also local RPM tests of Fedora 35 so if there is any local generated logs you need let me know

[ReenigneArcher]

one note: I have been building it without cuda, I dont know if you want to build with or have an option for one with and one without

Probably best to include it, I would think. Are there advantages to not including it?

Again, just to re-iterate. It would be best to have everything packaging inside the workflow, either via scripts or some other means. I will try to describe the automatons, so maybe it make more sense why this would be best.

trigger	event
PR submitted to this repo	action ensure PR is on nightly branch
PR submitted to nightly	build and package each version (AppImage, deb packages, Windows, Fedora (build only)), upload artifacts for testing
PR submitted to master	only allowed from nightly branch, same as PR submitted to nightly + verify that changelog and version number were updated
PR merged into master	same as PR submitted to master + use information from changelog to create release and upload packages as release assets

So basically the process of releasing is completely automated.

Perhaps we could add your spec file (once it's working) to this repo, and then use this github action (https://github.com/marketplace/actions/rpm-build) in our workflow to build the rpm?

Regarding why the build is failing, I'm not entirely sure and I'm no expert on Linux. Just comparing your spec file to the dockerfile this is what I notice.

• Development Tools is not added, see here: https://github.com/SunshineStream/Sunshine/blob/870b6e26753810f628608c0cf173f1f781da85db/scripts/Dockerfile-fedora_35#L5
• I actually forget what this line is doing (installing repos I think?), but I don't see that you have anything similar... maybe not needed for this case: https://github.com/SunshineStream/Sunshine/blob/870b6e26753810f628608c0cf173f1f781da85db/scripts/Dockerfile-fedora_35#L6

Then I notice you have some extra things not in the dockerfile, maybe not a big deal, but potentially one of them is interfering? Probably some of these should be added to the dockerfile as well.
BuildRequires: libboost_filesystem-devel
BuildRequires: libboost_log-devel
BuildRequires: libboost_system-devel
BuildRequires: libboost_thread-devel
BuildRequires: libboost_atomic-devel
BuildRequires: libcap-devel
BuildRequires: wayland-devel
BuildRequires: wayland-protocols-devel

[GeoDerp]

Perhaps we could add your spec file (once it's working) to this repo, and then use this github action (https://github.com/marketplace/actions/rpm-build) in our workflow to build the rpm?

Sounds like a plan

---

Having a look at it now, but I have used your docker file : in my local build
note: using silverblue (running version 35 of Fedora) and podman (ex.podman-compose)

./build-container.sh -f Dockerfile-fedora_35
./build-sunshine.sh -p -s ..

and I get:

...
-- found avutil: include /usr/include/ffmpeg lib /usr/lib64/libavutil.so
-- Checking for module 'swscale'
--   Package 'swscale', required by 'virtual:world', not found
-- look for newer strcture
-- Checking for module 'libswscale'
--   Found libswscale, version 5.9.100
-- Found swscale include dirs: /usr/include/ffmpeg
-- Using FFMpeg dir parent as hint: /usr/include
-- Found swscale libs: /usr/lib64/libswscale.so
-- found swscale: include /usr/include/ffmpeg lib /usr/lib64/libswscale.so
-- /usr/lib64/libavformat.so/usr/lib64/libavdevice.so/usr/lib64/libavcodec.so/usr/lib64/libavutil.so/usr/lib64/libswscale.so
-- Found FFMPEG: /usr/lib64/libavformat.so;/usr/lib64/libavdevice.so;/usr/lib64/libavcodec.so;/usr/lib64/libavutil.so;/usr/lib64/libswscale.so  
-- Configuring incomplete, errors occurred!
See also "/root/sunshine-build/CMakeFiles/CMakeOutput.log".
See also "/root/sunshine-build/CMakeFiles/CMakeError.log".

note: thats after adding "libcap-devel" to the dokerfile, as it was having an error with that first

[GeoDerp]

okay, I may have got it running inside of toolbox. Doing more testing...

[GeoDerp]

With the RPM's I can indeed confirm there are issues with the third party cbs files

more specifically:
cbs.dir/cbs_vp9.c.o
enet.dir/host.c.o

errors:

[ 12%] Building C object third-party/moonlight-common-c/enet/CMakeFiles/enet.dir/host.c.o
cd /var/home/Geo/rpmbuild/BUILD/sunshine-master/redhat-linux-build/third-party/moonlight-common-c/enet && /usr/bin/gcc -DHAS_FCNTL=1 -DHAS_GETADDRINFO=1 -DHAS_GETHOSTBYADDR_R=1 -DHAS_GETHOSTBYNAME_R=1 -DHAS_GETNAMEINFO=1 -DHAS_INET_NTOP=1 -DHAS_INET_PTON=1 -DHAS_IOCTL=1 -DHAS_MSGHDR_FLAGS=1 -DHAS_POLL=1 -DHAS_SOCKLEN_T=1 -I/var/home/Geo/rpmbuild/BUILD/sunshine-master/third-party/moonlight-common-c/enet/include -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -DNDEBUG   -Wno-error -MD -MT third-party/moonlight-common-c/enet/CMakeFiles/enet.dir/host.c.o -MF CMakeFiles/enet.dir/host.c.o.d -o CMakeFiles/enet.dir/host.c.o -c /var/home/Geo/rpmbuild/BUILD/sunshine-master/third-party/moonlight-common-c/enet/host.c
cc1: error: '-Wformat-security' ignored without '-Wformat' [-Werror=format-security]
cc1: error: '-Wformat-security' ignored without '-Wformat' [-Werror=format-security]
cc1: error: '-Wformat-security' ignored without '-Wformat' [-Werror=format-security]

or with build type set to debug DCMAKE_BUILD_TYPE=Debug

[ 12%] Building C object third-party/miniupnp/miniupnpc/CMakeFiles/libminiupnpc-static.dir/miniupnpc.c.o
cd /var/home/Geo/rpmbuild/BUILD/sunshine-master/redhat-linux-build/third-party/moonlight-common-c/enet && /usr/bin/gcc -DHAS_FCNTL=1 -DHAS_GETADDRINFO=1 -DHAS_GETHOSTBYADDR_R=1 -DHAS_GETHOSTBYNAME_R=1 -DHAS_GETNAMEINFO=1 -DHAS_INET_NTOP=1 -DHAS_INET_PTON=1 -DHAS_IOCTL=1 -DHAS_MSGHDR_FLAGS=1 -DHAS_POLL=1 -DHAS_SOCKLEN_T=1 -I/var/home/Geo/rpmbuild/BUILD/sunshine-master/third-party/moonlight-common-c/enet/include -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -g   -Wno-error -MD -MT third-party/moonlight-common-c/enet/CMakeFiles/enet.dir/callbacks.c.o -MF CMakeFiles/enet.dir/callbacks.c.o.d -o CMakeFiles/enet.dir/callbacks.c.o -c /var/home/Geo/rpmbuild/BUILD/sunshine-master/third-party/moonlight-common-c/enet/callbacks.c
cd /var/home/Geo/rpmbuild/BUILD/sunshine-master/redhat-linux-build/third-party/miniupnp/miniupnpc && /usr/bin/gcc -DMINIUPNPC_SET_SOCKET_TIMEOUT -DMINIUPNP_STATICLIB -D_BSD_SOURCE -D_DEFAULT_SOURCE -D_XOPEN_SOURCE=600 -I/var/home/Geo/rpmbuild/BUILD/sunshine-master/redhat-linux-build/third-party/miniupnp/miniupnpc -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -g -fPIC -Wall -MD -MT third-party/miniupnp/miniupnpc/CMakeFiles/libminiupnpc-static.dir/miniupnpc.c.o -MF CMakeFiles/libminiupnpc-static.dir/miniupnpc.c.o.d -o CMakeFiles/libminiupnpc-static.dir/miniupnpc.c.o -c /var/home/Geo/rpmbuild/BUILD/sunshine-master/third-party/miniupnp/miniupnpc/miniupnpc.c
cc1: error: '-Wformat-security' ignored without '-Wformat' [-Werror=format-security]
cc1: error: '-Wformat-security' ignored without '-Wformat' [-Werror=format-security]
cc1: error: '-Wformat-security' ignored without '-Wformat' [-Werror=format-security]
[ 14%] Building C object third-party/moonlight-common-c/enet/CMakeFiles/enet.dir/list.

[ 22%] Building C object third-party/cbs/CMakeFiles/cbs.dir/cbs_vp9.c.o
cd /var/home/Geo/rpmbuild/BUILD/sunshine-master/redhat-linux-build/third-party/cbs && /usr/bin/gcc -DCONFIG_CBS_AV1=1 -DCONFIG_CBS_H264=1 -DCONFIG_CBS_H265=1 -DCONFIG_CBS_JPEG=1 -DCONFIG_CBS_MPEG2=1 -DCONFIG_CBS_VP9=1 -DHAVE_FAST_UNALIGNED -DHAVE_THREADS=1 -DPIC=1 -DSUNSHINE_BUILD_DRM -DSUNSHINE_PLATFORM=\"linux\" -Dcbs_EXPORTS -I/var/home/Geo/rpmbuild/BUILD/sunshine-master/third-party/miniupnp -I/usr/include/libdrm -I/usr/include/libevdev-1.0 -I/var/home/Geo/rpmbuild/BUILD/sunshine-master/third-party/nv-codec-headers/include -I/var/home/Geo/rpmbuild/BUILD/sunshine-master/third-party/glad/include -I/var/home/Geo/rpmbuild/BUILD/sunshine-master -I/var/home/Geo/rpmbuild/BUILD/sunshine-master/third-party -I/var/home/Geo/rpmbuild/BUILD/sunshine-master/third-party/cbs/include -I/var/home/Geo/rpmbuild/BUILD/sunshine-master/third-party/moonlight-common-c/enet/include -I/var/home/Geo/rpmbuild/BUILD/sunshine-master/third-party/moonlight-common-c/reedsolomon -I/usr/include/ffmpeg -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -m64  -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -DNDEBUG -fPIC -Wall -Wno-incompatible-pointer-types -Wno-maybe-uninitialized -Wno-format -Wno-format-extra-args -MD -MT third-party/cbs/CMakeFiles/cbs.dir/cbs_vp9.c.o -MF CMakeFiles/cbs.dir/cbs_vp9.c.o.d -o CMakeFiles/cbs.dir/cbs_vp9.c.o -c /var/home/Geo/rpmbuild/BUILD/sunshine-master/third-party/cbs/cbs_vp9.c
cc1: error: '-Wformat-security' ignored without '-Wformat' [-Werror=format-security]

gmake[2]: Leaving directory '/var/home/Geo/rpmbuild/BUILD/sunshine-master/redhat-linux-build'
[ 46%] Built target enet
cc1: some warnings being treated as errors
gmake[2]: *** [third-party/cbs/CMakeFiles/cbs.dir/build.make:107: third-party/cbs/CMakeFiles/cbs.dir/cbs_av1.c.o] Error 1
cc1: some warnings being treated as errors
gmake[2]: *** [third-party/cbs/CMakeFiles/cbs.dir/build.make:93: third-party/cbs/CMakeFiles/cbs.dir/cbs_h2645.c.o] Error 1
gmake[2]: Leaving directory '/var/home/Geo/rpmbuild/BUILD/sunshine-master/redhat-linux-build'
gmake[1]: *** [CMakeFiles/Makefile2:237: third-party/cbs/CMakeFiles/cbs.dir/all] Error 2
gmake[1]: Leaving directory '/var/home/Geo/rpmbuild/BUILD/sunshine-master/redhat-linux-build'
gmake: *** [Makefile:94: all] Error 2

These are possibly errors you have always had. But because rpm building is more strict on the CMake, it only shows up here and not just as a warning

I dont have enough knowledge to know what varibles to feed cmake to give to full debug

for the reason why toolbox could build fine and not the Dockerfile, it could be a security issue, with toolbox patching in something that isnt configured in the Dockerfile, causing it to have issues. maybe some local binarys or the local Nvidia driver???

[ReenigneArcher]

Should we use cpack? https://cmake.org/cmake/help/latest/cpack_gen/rpm.html

[GeoDerp]

Should we use cpack? https://cmake.org/cmake/help/latest/cpack_gen/rpm.html

I dont see why not to try it. Been looking into it, however my cmake knowledge is low, so it will require a bit of effort to know now to modify the CMakeList to support CPack correctly.

On a side note: this might just be me, but when building, even with CUDA installed when running the cmake it spits out:

-- Looking for a CUDA compiler
-- Looking for a CUDA compiler - NOTFOUND

This could be just because im running the build in a toolbox session

Also, wayland is enabled in the cmake, however I dont believe sunshine has wayland support correct? (from my testing it just shows a black screen), or am I too tired and have gotten something wrong