Skip to content

ci: improve visual snapshot workflow setup#7051

Open
ElectricalBoy wants to merge 15 commits intomainfrom
snapshot-in-container
Open

ci: improve visual snapshot workflow setup#7051
ElectricalBoy wants to merge 15 commits intomainfrom
snapshot-in-container

Conversation

@ElectricalBoy
Copy link
Collaborator

@ElectricalBoy ElectricalBoy commented Feb 5, 2026

Summary

This PR removes installation step for playwright by making the entire workflow to run in a prebuilt container.

References

How did you test this change?

https://github.com/Liquipedia/Lua-Modules/actions/runs/21707583418/job/62602552921

@mbergen
Copy link
Collaborator

mbergen commented Feb 5, 2026

What exactly does this improve? runtime isn't any faster, and instead of install playwright we now install build essentials.

@ElectricalBoy
Copy link
Collaborator Author

instead of install playwright we now install build essentials.

yeah I mentioned that too

@FO-nTTaX FO-nTTaX removed their request for review February 5, 2026 12:16
@FO-nTTaX
Copy link
Member

FO-nTTaX commented Feb 5, 2026

I have no opinion on the visual snapshot testing, so I removed myself from reviewers

@Rathoz
Copy link
Collaborator

Rathoz commented Feb 5, 2026

What exactly does this improve? runtime isn't any faster, and instead of install playwright we now install build essentials.

Setting up the dependencies takes 60s instead of 90-120s, so saving 30-60s is something

@mbergen
Copy link
Collaborator

mbergen commented Feb 5, 2026

Setting up the dependencies takes 60s instead of 90-120s, so saving 30-60s is something

What am i missing? I don't see that speedup in the action run here.
The time is just spread across different steps, notably container fetch/startup and build tool installation.

@ElectricalBoy
Copy link
Collaborator Author

What am i missing? I don't see that speedup in the action run here.
The time is just spread across different steps, notably container fetch/startup and build tool installation.

it used to take (and still does every once in a while) stupid long just to get Playwright set up
see examples below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants