ci: improve visual snapshot workflow setup#7051
Conversation
759c68a to
5b0612d
Compare
|
What exactly does this improve? runtime isn't any faster, and instead of install playwright we now install build essentials. |
yeah I mentioned that too |
This reverts commit 46448e8.
|
I have no opinion on the visual snapshot testing, so I removed myself from reviewers |
Setting up the dependencies takes 60s instead of 90-120s, so saving 30-60s is something |
What am i missing? I don't see that speedup in the action run here. |
it used to take (and still does every once in a while) stupid long just to get Playwright set up |
Summary
This PR removes installation step for playwright by making the entire workflow to run in a prebuilt container.
References
How did you test this change?
https://github.com/Liquipedia/Lua-Modules/actions/runs/21707583418/job/62602552921