Open
Conversation
Exceeded timeout to 5000ms (2000ms is default) because it sometimes takes more than 2000ms to execute.
not sure why it was like that
Contributor
Author
|
Oh.. I just realized I made a mess by including pull request with windows support as well. Will try to fix it asap. |
Contributor
Author
|
I did my best to clear the mess I made. If it's still not acceptable let me know and I will just open a new "clear" pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes:
setVolumepreviously wasn't working as intended for example:setVolume(15, cb)was setting volume to16instead of15butsetVolume(50, cb)was correctly setting volume to50. Now it works for all the values0-100%.Since only @RyanAfrish7 (Ubuntu 16.04 LTS) and I (Ubuntu 14.04 LTS) reported problems fixed in this pull request I assume these errors only appeared on various Ubuntu distributions.