Fixed find middleware when selector is a component created with createClass #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for this! :) |
zackify
added a commit
that referenced
this pull request
Nov 2, 2015
Fixed find middleware when selector is a component created with createClass
Contributor
Author
|
👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
findmiddleware is using thenameproperty on the component class passed in as an argument which was causing an issue with components created withReact.createClassthat don't have thenameattribute. I fixed this by falling back todisplayNamein this case.Although using
createClassis not the recommended way to create React components, some third-party libraries still use it, so I think thefindmiddleware should support it until it's officially deprecated in React.