Conversation
Collaborator
|
LGTM. |
kostis
added a commit
that referenced
this pull request
Feb 2, 2026
kostis
added a commit
that referenced
this pull request
Feb 16, 2026
kostis
added a commit
that referenced
this pull request
Mar 6, 2026
* Fix some Javadoc comments
* Add missing Override annotations
* Remove a redundant control flow continue statement
* Fix an erroneous boxed primitive equality comparison
* Remove public from methods which are effectively private
* Remove some unnecessary parentheses
* Make a public constant array private
* Remove two unused methods
* Simplify code by using instanceof with a variable
* Add an extra assertion to a test
* Remove or comment out some unnecessary code from tests
* Add a missing toString() call
* Sanitize the compareTo comparison to be zero
It's an implementation detail whether compareTo returns {-1, 0, 1} or
some other value, so all comparisons should be against zero.
* Add missing cases in two switch statements
* Remove unused code from tests
* Remove unused, and often confusing, code
* Use Integer.hashCode() instead of Objects,hashCode()
* Replace uses of LinkedList with ArrayList or ArrayDeque
These libraries are more efficient in most cases.
In a few places where this was not possible, some @SuppressWarning
annotations were used instead.
* Remove the suppression of the BadInstanceof check
* Fix unchecked exceptions in test files
* Remove some unused code after #131
* Suppress warnings of IterableAndIterator
* Suppress warnings of NonApiType(s)
* Convert some statement switches to expression switches
* Substitute comparisons of reference equality by value equality
* Add a missing toString()
* Use String.split() with two arguments instead of one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following code
in the method
CTInnerNode#refinedoes not do anything since it will never be the case thatuis not an instance ofShortPrefix. The intent is to make sure that prefixes which are short remain short after being sifted into the classification tree following refinement. Since this is already handled byClassificationTree#refine, it is not necessary to have that check here. This PR therefore removes the code.