Fix undo to skip ignored messages#330
Open
gergesh wants to merge 1 commit intoLatitudes-Dev:integrationfrom
Open
Fix undo to skip ignored messages#330gergesh wants to merge 1 commit intoLatitudes-Dev:integrationfrom
gergesh wants to merge 1 commit intoLatitudes-Dev:integrationfrom
Conversation
Additional Comments (2)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! Prompt To Fix With AIThis is a comment left during a code review.
Path: packages/opencode/src/cli/cmd/tui/routes/session/index.tsx
Line: 543
Comment:
add fallback to match pattern used elsewhere in this file
```suggestion
const parts = sync.data.part[message.id] ?? []
```
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! Prompt To Fix With AIThis is a comment left during a code review.
Path: packages/opencode/src/cli/cmd/tui/routes/session/index.tsx
Line: 572
Comment:
redo should likely also skip ignored messages for consistency with undo behavior
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Greptile Summary
Enhanced the undo functionality to skip over messages where all text parts are marked as ignored by DCP, ensuring users revert to the last meaningful message.
some()to verify at least one text part exists that isn't ignoredMinor issues:
sync.data.part[message.id]on line 543 (should use?? []fallback)Confidence Score: 4/5
?? []), and consider updating redo at line 572 for consistencyImportant Files Changed
Last reviewed commit: dc7314f