LKSM: Multivalue text choice automation: Sample Finder MVFK#2928
Merged
LKSM: Multivalue text choice automation: Sample Finder MVFK#2928
Conversation
fixes for mvtc values in other tests bitmaskSelect for selecting mvtc values
labkey-tchad
reviewed
Apr 1, 2026
Comment on lines
+193
to
+196
| // Use i + 1 as a bitmask so each row gets a deterministic, non-empty subset of choices, | ||
| // consistent with how other field types (Integer, Boolean, TextChoice) use i for predictable data. | ||
| // Salt with queryName hash so different entity types produce distinct MVTC values at the same row index. | ||
| List<String> values = bitmaskSelect(validator.getValues(), i + 1, queryName.hashCode()); |
Member
There was a problem hiding this comment.
Other than string fields, all of the other data types have predictable values based only on the row index. Why do MVTC values need to be distinct between different queries?
Contributor
Author
There was a problem hiding this comment.
The main problem is the testMVTCWithMPlusNAncestors() test. Since MVTC values are based only on a row index, they are the same for Sources, Parents, and Samples with that index. This means sorting and filtering results are also identical, which I think results in poor test coverage.
labkey-tchad
approved these changes
Apr 7, 2026
Comment on lines
+501
to
+505
| public String getNamePart() | ||
| { | ||
| return _namePart; | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Add getNamePart to FieldInfo instead. It's guaranteed to be non-null there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Make MVTC selections more predictable using bitmaskSelect.
Related Pull Requests