Show protein context above precursor list in QC plots#1197
Open
ankurjuneja wants to merge 5 commits intorelease26.3-SNAPSHOTfrom
Open
Show protein context above precursor list in QC plots#1197ankurjuneja wants to merge 5 commits intorelease26.3-SNAPSHOTfrom
ankurjuneja wants to merge 5 commits intorelease26.3-SNAPSHOTfrom
Conversation
Contributor
Author
|
Contributor
labkey-jeckels
left a comment
labkey-jeckels
left a comment
There was a problem hiding this comment.
Initial review looks good. A couple of questions/suggestions.
| seriesColors.add(color); | ||
|
|
||
| // set the peptide group (protein / molecule list) for the combined plot tree legend | ||
| PeptideGroup peptideGroup = PeptideGroupManager.getPeptideGroup(c, molecule.getPeptideGroupId()); |
Contributor
There was a problem hiding this comment.
Many children may reference the same peptideGroup. Add a simple cache to avoid duplicate lookups
| d3.selectAll('path.line').attr('fill-opacity', 1).attr('stroke-opacity', 1); | ||
| d3.selectAll('.legend .legend-item').attr('fill-opacity', 1).attr('stroke-opacity', 1); | ||
| d3.selectAll('.legend .legend-item').each(function(d) { | ||
| var opacity = (d && d.name && !d.separator && hidden[d.hoverText || d.name.split('|')[0]]) ? 0.3 : 1; |
Contributor
There was a problem hiding this comment.
There are a lot of split('|') calls here. Should we use a constant? I'm not seeing where the value is being concatenated, but is there a risk of the values having a pipe in them and confusing our splitting?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
https://github.com/LabKey/internal-issues/issues/1043
Related Pull Requests
Changes