Skip to content

use extension point from gh-plugin to get hooks#16

Merged
lanwen merged 2 commits intoKostyaSha:masterfrom
lanwen:gh-hook
Jul 20, 2015
Merged

use extension point from gh-plugin to get hooks#16
lanwen merged 2 commits intoKostyaSha:masterfrom
lanwen:gh-hook

Conversation

@lanwen
Copy link
Contributor

@lanwen lanwen commented Jul 19, 2015

after jenkinsci/github-plugin#60 we can use gh-plugin endpoint instead of own

Review on Reviewable

@KostyaSha
Copy link
Owner

interesting why pr build failed...

@KostyaSha KostyaSha closed this Jul 19, 2015
@KostyaSha KostyaSha reopened this Jul 19, 2015
@jenkinsadmin
Copy link

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@lanwen
Copy link
Contributor Author

lanwen commented Jul 19, 2015

because of

CONFLICT (content): Merge conflict in pom.xml

@KostyaSha
Copy link
Owner

because of

No, it was bad before

@lanwen lanwen force-pushed the gh-hook branch 2 times, most recently from a24039a to 2bf79a9 Compare July 19, 2015 22:09
MerkushevKirill added 2 commits July 20, 2015 01:13
+ also make github in subscriber anonymous connected, as of it only needs to parse payload
@lanwen lanwen changed the title [WiP] use extension point from gh-plugin to get hooks use extension point from gh-plugin to get hooks Jul 19, 2015
@KostyaSha
Copy link
Owner

👍

lanwen added a commit that referenced this pull request Jul 20, 2015
use extension point from gh-plugin to get hooks
@lanwen lanwen merged commit 02d1df0 into KostyaSha:master Jul 20, 2015
@lanwen lanwen deleted the gh-hook branch July 20, 2015 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments