First-pass native video ffmpeg display setting to prevent transcoding, when selected#1567
Open
mattdawkins wants to merge 8 commits intomainfrom
Open
First-pass native video ffmpeg display setting to prevent transcoding, when selected#1567mattdawkins wants to merge 8 commits intomainfrom
mattdawkins wants to merge 8 commits intomainfrom
Conversation
BryonLewis
reviewed
Jan 8, 2026
Comment on lines
+188
to
+197
| async function processBatches( | ||
| batches: number[][], | ||
| videoPath: string, | ||
| fps: number, | ||
| ): Promise<void> { | ||
| if (batches.length === 0) return; | ||
| const [batch, ...remaining] = batches; | ||
| await Promise.all(batch.map((frame) => extractFrame(videoPath, frame, fps).catch(() => null))); | ||
| await processBatches(remaining, videoPath, fps); | ||
| } |
Collaborator
There was a problem hiding this comment.
I'd have to look into how this specific ffmpeg comand works (in extractFrame) but I'm guessing you probably wouldn't want to be spawning a new process for each frame because of the overhead. There should be an option to be able to a range of frames in a single process.
Member
Author
There was a problem hiding this comment.
I have a follow-up to address this with an optional setting, but it depends on code in the other branch landing first (the multi-camera option)
mattdawkins
force-pushed
the
add-native-option
branch
2 times, most recently
from
e727497 to
73a7e8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.