Adjust depends expression for VK_KHR_swapchain_maintenance1 #2646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This looks right to me. |
|
Seems like |
Contributor
Author
|
@bjornbytes Thanks, I added that too |
Contributor
|
SI TSG discussion today: Agreed this is the correct fix. Assigning @mematthias to resolve the CI issues, and then this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes an adjustment to the depends expression of
VK_KHR_swapchain_maintenance1.I am not fully certain this is the intended definition, but the change appears to better reflect the logical and practical dependencies of the extension.