Remove ArrayInterfaceCore dependency #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArrayInterface 7.x, which is already required, switched to using package extensions and removed the ArrayInterfaceCore package. Get rid of that dependency and use the symbols directly from ArrayInterface instead. (These two symbols are just aliases of types from other packages which is why this still works right now.)
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #511 +/- ##
==========================================
+ Coverage 86.99% 88.76% +1.76%
==========================================
Files 39 39
Lines 9596 9600 +4
==========================================
+ Hits 8348 8521 +173
+ Misses 1248 1079 -169
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArrayInterface 7.x, which is already required, switched to using package extensions and removed the ArrayInterfaceCore package.
Get rid of that dependency and use the symbols directly from ArrayInterface instead.
(These two symbols are just aliases of types from other packages which is why this still works right now.)