Skip to content

Conversation

@ararslan
Copy link
Member

The commit here is freebsd/freebsd-src@1cbd288, which fixed this upstream. The commit authorship is preserved, and the commit message is reproduced below:

Fix a bug in remquo{,f,l}, in which the quotient didn't always have the correct sign when the remainder was 0.

Fix a separate bug in remquo alone, in which the remainder and quotient were both off by a bit in certain cases involving subnormal remainders.

The bugs affected all platforms except amd64 and i386, on which the routines are implemented in assembly.

PR: 166463
Submitted by: Ilya Burylov
MFC after: 2 weeks

Fixes #283

…he correct sign when the remainder was 0.

Fix a separate bug in remquo alone, in which the remainder and
quotient were both off by a bit in certain cases involving subnormal
remainders.

The bugs affected all platforms except amd64 and i386, on which the
routines are implemented in assembly.

PR:		166463
Submitted by:	Ilya Burylov
MFC after:	2 weeks
@ViralBShah ViralBShah merged commit 5a33b6b into master Jan 10, 2025
16 checks passed
@ViralBShah ViralBShah deleted the aa/remquo branch January 10, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C versions of remquo deliver wrong quotient if x == -y

3 participants