Skip to content

Correct long double check in CMakeLists.txt and remove duplicate definitions for static library builds too #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ViralBShah merged 2 commits into from
Jan 16, 2024
Merged

Correct long double check in CMakeLists.txt and remove duplicate definitions for static library builds too #293

ViralBShah merged 2 commits into from
Jan 16, 2024

Conversation

@ryonaldteofilo
Copy link
Contributor

@ryonaldteofilo ryonaldteofilo commented Jan 12, 2024

  • Fixed cmake aarch64 build for macOS due to a mistake in long double == double size check, this should fix CMake build fails on macOS arm64/aarch64 #292 .
  • Apply the filtering out of C implementation if native implementation exists for static library builds as well.
  • Default to building a shared library just like the GNU make build, and updated the README to reflect this.

@ryonaldteofilo
Copy link
Contributor Author

ryonaldteofilo commented Jan 12, 2024

Probably should mention that I've confirmed that this indeed does fix #292 :)

@ViralBShah ViralBShah merged commit f3eec73 into JuliaMath:master Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CMake build fails on macOS arm64/aarch64

2 participants

@ryonaldteofilo @ViralBShah