Skip to content

Conversation

@A1phaN
Copy link
Contributor

@A1phaN A1phaN commented Jun 30, 2023

Support for LoongArch64, a new ISA developed by Loongson Company which is already supported by glibc.

@loongson-zjl
Copy link

Could someone please review this pull request?

@oscardssmith
Copy link
Member

From the perspective of someone who doesn't know anything about the architecture there's nothing that looks inherently unreasonable, but it's hard to review a PR for an architecture I've never heard of.

@loongson-zjl
Copy link

From the perspective of someone who doesn't know anything about the architecture there's nothing that looks inherently unreasonable, but it's hard to review a PR for an architecture I've never heard of.

The LoongArch 'Loong64' architecture has been recently added to Debian Ports. However, there has been an issue with the openlibm package. (https://buildd.debian.org/status/package.php?p=openlibm&suite=sid)

We would like to add support for LoongArch in openlibm , is there anything specific that I should do to help address this issue?

Do we need any additional tests, documentation, or a specific environment to ensure that openlibm works well with LoongArch?

@loongson-zjl
Copy link

Support for LoongArch64, a new ISA developed by Loongson Company which is already supported by glibc.
did you test in a loongarch64 machine ?

@ViralBShah
Copy link
Member

While I have no access to such machines, I don't see a challenge merging this - assuming the loongarch devs will maintain. Does it at least pass the bundled tests?

@ViralBShah ViralBShah merged commit eb5330e into JuliaMath:master Jan 10, 2024
@ViralBShah
Copy link
Member

If the tests are passing, can you also add a mention of the architecture to the README?

algitbot pushed a commit to alpinelinux/aports that referenced this pull request May 23, 2024
The upstream code already supports loongarch64 and will
be disabled before the next release.
see:
JuliaMath/openlibm#280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants