-
Notifications
You must be signed in to change notification settings - Fork 40
Parametrize struct definitions of random matrix ensemble types #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #96 +/- ##
=======================================
Coverage 42.65% 42.65%
=======================================
Files 12 12
Lines 830 830
=======================================
Hits 354 354
Misses 476 476 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dlfivefifty ping for review |
| GaussianHermite(β) = GaussianHermite{β}() | ||
| struct GaussianHermite{B} <: ContinuousMatrixDistribution | ||
| beta::B | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not sure this change is a good idea since GUE, GOE, and GSE are very different and should be different types.
for general β this makes sense. Though my personal preference would be to use Unicode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair, I'll revert this. I guess with that in mind, would it be good to parametrize other ensemble types this way, e.g. Ginibre{4}?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so. Especially if the code consists of a lot of special cases if β == 1, elseif β ==2, elseif β == 4 end then that hints that they actually should be treated as different types via parameterisation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK sounds good.
See #91.